From: amit.kucheria@canonical.com (Amit Kucheria)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: i.MX50/53: debug-macro: fix UART_PADDR
Date: Mon, 11 Jul 2011 12:06:09 +0300 [thread overview]
Message-ID: <20110711090609.GB2482@matterhorn1> (raw)
In-Reply-To: <1310251913-9877-1-git-send-email-troy.kisky@boundarydevices.com>
On 11 Jul 09, Troy Kisky wrote:
> The i.MX51 UART_PADDR value does not work for MX50/53.
>
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
Acked-by: Amit Kucheria <amit.kucheria@canonical.com>
but I think we should switch to runtime detection of the machine (machine
ID?) and then set the port address.
See arch/arm/plat-omap/include/plat/uncompress.h for a possible scheme.
> ---
> arch/arm/plat-mxc/include/mach/debug-macro.S | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-mxc/include/mach/debug-macro.S b/arch/arm/plat-mxc/include/mach/debug-macro.S
> index 8e8d175..3919ad4 100644
> --- a/arch/arm/plat-mxc/include/mach/debug-macro.S
> +++ b/arch/arm/plat-mxc/include/mach/debug-macro.S
> @@ -37,13 +37,20 @@
> #define UART_PADDR MX3x_UART1_BASE_ADDR
> #endif
>
> -#ifdef CONFIG_ARCH_MX5
> +#ifdef CONFIG_ARCH_MX51
> #ifdef UART_PADDR
> #error "CONFIG_DEBUG_LL is incompatible with multiple archs"
> #endif
> #define UART_PADDR MX51_UART1_BASE_ADDR
> #endif
>
> +#if defined(CONFIG_ARCH_MX50) || defined(CONFIG_ARCH_MX53)
> +#ifdef UART_PADDR
> +#error "CONFIG_DEBUG_LL is incompatible with multiple archs"
> +#endif
> +#define UART_PADDR MX53_UART1_BASE_ADDR
> +#endif
> +
> #define UART_VADDR IMX_IO_ADDRESS(UART_PADDR)
>
> .macro addruart, rp, rv
> --
> 1.7.0.4
>
--
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || amit.kucheria at canonical.com
----------------------------------------------------------------------
next prev parent reply other threads:[~2011-07-11 9:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 22:51 [PATCH 1/1] ARM: i.MX50/53: debug-macro: fix UART_PADDR Troy Kisky
2011-07-11 9:06 ` Amit Kucheria [this message]
2011-07-11 9:30 ` Uwe Kleine-König
2011-07-11 10:08 ` Amit Kucheria
2011-07-11 13:58 ` Uwe Kleine-König
2011-07-12 13:32 ` Sascha Hauer
2011-07-12 17:04 ` Troy Kisky
2011-07-15 7:56 ` Sascha Hauer
2011-07-20 13:13 ` [PATCH] arm/mxc: add the missing UART_PADDR for i.mx53 Shawn Guo
2011-07-20 13:08 ` Wolfram Sang
2011-07-20 13:24 ` Shawn Guo
2011-07-20 13:27 ` Wolfram Sang
2011-07-20 13:44 ` Shawn Guo
2011-07-20 13:45 ` Wolfram Sang
2011-07-20 13:59 ` Shawn Guo
2011-07-20 20:44 ` Wolfram Sang
2011-07-20 20:13 ` Troy Kisky
2011-07-20 23:13 ` Shawn Guo
2011-07-20 13:40 ` Shawn Guo
2011-07-20 21:10 ` Troy Kisky
2011-07-20 23:16 ` Shawn Guo
2011-07-21 0:31 ` Troy Kisky
-- strict thread matches above, loose matches on Subject: below --
2011-07-12 2:40 [PATCH 1/1] ARM: i.MX50/53: debug-macro: fix UART_PADDR Troy Kisky
2011-07-12 7:44 ` Uwe Kleine-König
2011-07-12 13:34 ` Sascha Hauer
2011-07-12 16:48 ` Troy Kisky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711090609.GB2482@matterhorn1 \
--to=amit.kucheria@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox