[patch 0/3] imx: Efika: Add pata device

[patch 0/3] imx: Efika: Add pata device

[Arnaud Patard (Rtp)]

This patchset is adding ressources, clock and device declarations for the
pata device available on imx51. Last patch enables pata on efika platforms.
To be complete, this patchset needs a driver, which is about to be sent for
merge to ata developers.

Arnaud

[patch 1/3] imx51: add pata device

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efika_pata_add_dev.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110716/2aaa6629/attachment.ksh>

[patch 2/3] imx51: add pata clock

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efika_pata_add_clock.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110716/654b3c77/attachment.ksh>

[patch 3/3] imx: efika: Enable pata.

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efika_pata_enable_pata.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110716/d540e83d/attachment.ksh>

[patch 1/3] imx51: add pata device

[Uwe Kleine-König]

On Sat, Jul 16, 2011 at 10:44:12PM +0200, Arnaud Patard wrote:
> Declare the pata device found on mx51
> 
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
---
> Index: linux-2.6-submit/arch/arm/mach-mx5/devices-imx51.h
> ===================================================================
> --- linux-2.6-submit.orig/arch/arm/mach-mx5/devices-imx51.h	2011-07-16 16:16:40.000000000 +0200
> +++ linux-2.6-submit/arch/arm/mach-mx5/devices-imx51.h	2011-07-16 16:20:33.000000000 +0200
> @@ -52,3 +52,5 @@ extern const struct imx_mxc_pwm_data imx
>  extern const struct imx_imx_keypad_data imx51_imx_keypad_data;
>  #define imx51_add_imx_keypad(pdata)	\
>  	imx_add_imx_keypad(&imx51_imx_keypad_data, pdata)
> +
> +extern const struct imx_mxc_pata_data im51_mxc_pata_data;
imx51 please

> Index: linux-2.6-submit/arch/arm/plat-mxc/devices/Kconfig
> ===================================================================
> --- linux-2.6-submit.orig/arch/arm/plat-mxc/devices/Kconfig	2011-07-16 16:16:40.000000000 +0200
> +++ linux-2.6-submit/arch/arm/plat-mxc/devices/Kconfig	2011-07-16 16:20:08.000000000 +0200
> @@ -31,6 +31,9 @@ config IMX_HAVE_PLATFORM_IMX_I2C
>  config IMX_HAVE_PLATFORM_IMX_KEYPAD
>  	bool
>  
> +config IMX_HAVE_PLATFORM_IMX_PATA
> +	bool
> +
>  config IMX_HAVE_PLATFORM_IMX_SSI
>  	bool
>  
> Index: linux-2.6-submit/arch/arm/plat-mxc/devices/Makefile
> ===================================================================
> --- linux-2.6-submit.orig/arch/arm/plat-mxc/devices/Makefile	2011-07-16 16:16:40.000000000 +0200
> +++ linux-2.6-submit/arch/arm/plat-mxc/devices/Makefile	2011-07-16 16:20:08.000000000 +0200
> @@ -10,6 +10,7 @@ obj-y += platform-imx-dma.o
>  obj-$(CONFIG_IMX_HAVE_PLATFORM_IMX_FB) += platform-imx-fb.o
>  obj-$(CONFIG_IMX_HAVE_PLATFORM_IMX_I2C) += platform-imx-i2c.o
>  obj-$(CONFIG_IMX_HAVE_PLATFORM_IMX_KEYPAD) += platform-imx-keypad.o
> +obj-$(CONFIG_IMX_HAVE_PLATFORM_IMX_PATA) += platform-imx-pata.o
>  obj-$(CONFIG_IMX_HAVE_PLATFORM_IMX_SSI) += platform-imx-ssi.o
>  obj-$(CONFIG_IMX_HAVE_PLATFORM_IMX_UART) += platform-imx-uart.o
>  obj-$(CONFIG_IMX_HAVE_PLATFORM_IMX_UDC) += platform-imx_udc.o
> Index: linux-2.6-submit/arch/arm/plat-mxc/devices/platform-imx-pata.c
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ linux-2.6-submit/arch/arm/plat-mxc/devices/platform-imx-pata.c	2011-07-16 16:20:08.000000000 +0200
> @@ -0,0 +1,38 @@
> +/*
> + * This program is free software; you can redistribute it and/or modify it under
> + * the terms of the GNU General Public License version 2 as published by the
> + * Free Software Foundation.
> + */
> +#include <mach/hardware.h>
> +#include <mach/devices-common.h>
> +
> +#define imx_mxc_pata_data_entry_single(soc)				\
> +	{								\
> +		.iobase = soc ## _ATA_BASE_ADDR,			\
> +		.irq = soc ## _MXC_INT_ATA,				\
> +	}
> +
> +#ifdef CONFIG_SOC_IMX51
> +const struct imx_mxc_pata_data im51_mxc_pata_data __initconst =
> +	imx_mxc_pata_data_entry_single(MX51);
obviously here, too

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[patch 3/3] imx: efika: Enable pata.

[Uwe Kleine-König]

On Sat, Jul 16, 2011 at 10:44:14PM +0200, Arnaud Patard wrote:
> Enable pata support on efika mx/sb platforms.
> 
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> Index: linux-2.6-submit/arch/arm/mach-mx5/Kconfig
> ===================================================================
> --- linux-2.6-submit.orig/arch/arm/mach-mx5/Kconfig	2011-07-16 16:19:53.000000000 +0200
> +++ linux-2.6-submit/arch/arm/mach-mx5/Kconfig	2011-07-16 16:22:34.000000000 +0200
> @@ -147,6 +147,7 @@ config MX51_EFIKA_COMMON
>  	bool
>  	select SOC_IMX51
>  	select IMX_HAVE_PLATFORM_IMX2_WDT
> +	select IMX_HAVE_PLATFORM_IMX_PATA
>  	select IMX_HAVE_PLATFORM_IMX_UART
>  	select IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX
>  	select IMX_HAVE_PLATFORM_SPI_IMX
> Index: linux-2.6-submit/arch/arm/mach-mx5/mx51_efika.c
> ===================================================================
> --- linux-2.6-submit.orig/arch/arm/mach-mx5/mx51_efika.c	2011-07-16 16:19:53.000000000 +0200
> +++ linux-2.6-submit/arch/arm/mach-mx5/mx51_efika.c	2011-07-16 16:21:22.000000000 +0200
> @@ -629,6 +629,8 @@ void __init efika_board_common_init(void
>  		ARRAY_SIZE(mx51_efika_spi_board_info));
>  	imx51_add_ecspi(0, &mx51_efika_spi_pdata);
>  
> +	imx_add_mxc_pata(&im51_mxc_pata_data);
> +
I'd prefer to have imx51_add_mxc_pata() which expands to
imx_add_mxc_pata(&imx51_mxc_pata_data)

Why didn't you add that?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[patch 0/3] imx: Efika: Add pata device

[Arnaud Patard (Rtp)]

This patchset is adding ressources, clock and device declarations for the
pata device available on imx51. Last patch enables pata on efika platforms.
To be complete, this patchset needs a driver, which is about to be sent for
merge to ata developers.

v2: created a imx51_add_mxc_pata() as suggested

Arnaud

[patch 0/3] imx: Efika: Add pata device

[Arnaud Patard (Rtp)]

This patchset is adding ressources, clock and device declarations for the
pata device available on imx51. Last patch enables pata on efika platforms.
To be complete, this patchset needs a driver, which is about to be sent for
merge to ata developers.

v2: Created a imx51_add_mxc_pata() as suggested
v3: Fix naming

Arnaud

[patch 0/3] imx: Efika: Add pata device

[Arnaud Patard (Rtp)]

This patchset is adding ressources, clock and device declarations for the
pata device available on imx51. Last patch enables pata on efika platforms.
To be complete, this patchset needs a driver, which is about to be sent for
merge to ata developers.

v2: Created a imx51_add_mxc_pata() as suggested
v3: Fix naming
v4: Change clock name to pata_imx

Arnaud