From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 3/3] imx: efika: Enable pata.
Date: Sat, 16 Jul 2011 23:24:29 +0200 [thread overview]
Message-ID: <20110716212429.GB1233@pengutronix.de> (raw)
In-Reply-To: <20110716210155.452675636@rtp-net.org>
On Sat, Jul 16, 2011 at 10:44:14PM +0200, Arnaud Patard wrote:
> Enable pata support on efika mx/sb platforms.
>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> Index: linux-2.6-submit/arch/arm/mach-mx5/Kconfig
> ===================================================================
> --- linux-2.6-submit.orig/arch/arm/mach-mx5/Kconfig 2011-07-16 16:19:53.000000000 +0200
> +++ linux-2.6-submit/arch/arm/mach-mx5/Kconfig 2011-07-16 16:22:34.000000000 +0200
> @@ -147,6 +147,7 @@ config MX51_EFIKA_COMMON
> bool
> select SOC_IMX51
> select IMX_HAVE_PLATFORM_IMX2_WDT
> + select IMX_HAVE_PLATFORM_IMX_PATA
> select IMX_HAVE_PLATFORM_IMX_UART
> select IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX
> select IMX_HAVE_PLATFORM_SPI_IMX
> Index: linux-2.6-submit/arch/arm/mach-mx5/mx51_efika.c
> ===================================================================
> --- linux-2.6-submit.orig/arch/arm/mach-mx5/mx51_efika.c 2011-07-16 16:19:53.000000000 +0200
> +++ linux-2.6-submit/arch/arm/mach-mx5/mx51_efika.c 2011-07-16 16:21:22.000000000 +0200
> @@ -629,6 +629,8 @@ void __init efika_board_common_init(void
> ARRAY_SIZE(mx51_efika_spi_board_info));
> imx51_add_ecspi(0, &mx51_efika_spi_pdata);
>
> + imx_add_mxc_pata(&im51_mxc_pata_data);
> +
I'd prefer to have imx51_add_mxc_pata() which expands to
imx_add_mxc_pata(&imx51_mxc_pata_data)
Why didn't you add that?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-07-16 21:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-16 20:44 [patch 0/3] imx: Efika: Add pata device Arnaud Patard (Rtp)
2011-07-16 20:44 ` [patch 1/3] imx51: add " Arnaud Patard (Rtp)
2011-07-16 21:22 ` Uwe Kleine-König
2011-07-16 20:44 ` [patch 2/3] imx51: add pata clock Arnaud Patard (Rtp)
2011-07-16 20:44 ` [patch 3/3] imx: efika: Enable pata Arnaud Patard (Rtp)
2011-07-16 21:24 ` Uwe Kleine-König [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-22 10:37 [patch 0/3] imx: Efika: Add pata device Arnaud Patard (Rtp)
2011-07-22 10:37 ` [patch 3/3] imx: efika: Enable pata Arnaud Patard (Rtp)
2011-07-24 18:39 [patch 0/3] imx: Efika: Add pata device Arnaud Patard (Rtp)
2011-07-24 18:39 ` [patch 3/3] imx: efika: Enable pata Arnaud Patard (Rtp)
2011-07-26 14:54 [patch 0/3] imx: Efika: Add pata device Arnaud Patard (Rtp)
2011-07-26 14:54 ` [patch 3/3] imx: efika: Enable pata Arnaud Patard (Rtp)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110716212429.GB1233@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).