From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] Input: gpio-keys: do not reference platform_data after .probe exits
Date: Mon, 18 Jul 2011 10:24:21 -0700 [thread overview]
Message-ID: <201107181024.22134.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <CACxGe6tFt4h-iVjM26BdD9oLj2Zd+z8i1naR0YU3AbLtGzmXgA@mail.gmail.com>
On Monday, July 18, 2011 10:15:27 AM Grant Likely wrote:
> On Mon, Jul 18, 2011 at 11:02 AM, Dmitry Torokhov
>
> <dmitry.torokhov@gmail.com> wrote:
> > On Monday, July 18, 2011 09:45:07 AM Shawn Guo wrote:
> >> The patch makes a copy of platform data into driver data, so that any
> >> reference to platform_data after .probe exits can be avoided.
> >
> > And why is this beneficial? I am of the opinion that platform data
> > should stay on (and be accessed through a const pointer to ensure
> > that the driver will not alter it).
>
> Because when using the device tree, there is no platform_data.
>
So allocate it... That's what Davids patch does. BTW, you never gave
ACK for the final version and I'd prefer to have it for the DT bindings.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2011-07-18 17:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 16:45 [PATCH 0/2] add device tree probe support for gpio_keys Shawn Guo
2011-07-18 16:45 ` [PATCH 1/2] Input: gpio-keys: do not reference platform_data after .probe exits Shawn Guo
2011-07-18 17:02 ` Dmitry Torokhov
2011-07-18 17:15 ` Grant Likely
2011-07-18 17:24 ` Dmitry Torokhov [this message]
2011-07-19 1:17 ` Shawn Guo
2011-07-19 7:48 ` Russell King - ARM Linux
2011-07-19 8:56 ` Shawn Guo
2011-07-18 16:45 ` [PATCH 2/2] Input: gpio-keys: add device tree probe support Shawn Guo
2011-07-18 17:05 ` Dmitry Torokhov
2011-07-19 1:22 ` Shawn Guo
2011-07-19 3:55 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107181024.22134.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox