From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: mxs-dma: reset after disable channel
Date: Tue, 19 Jul 2011 16:45:37 +0800 [thread overview]
Message-ID: <20110719084536.GH3838@S2100-06.ap.freescale.net> (raw)
In-Reply-To: <20110719082146.GA1951@pengutronix.de>
On Tue, Jul 19, 2011 at 10:21:46AM +0200, Wolfram Sang wrote:
> On Tue, Jul 19, 2011 at 12:02:16PM +0800, Shawn Guo wrote:
> > On Tue, Jul 19, 2011 at 12:09:56PM +0800, Dong Aisheng wrote:
> > > We met some channels in abnormal state after disable.
> > > Reset it to get a clean state.
> > >
> > > Signed-off-by: Dong Aisheng <b29396@freescale.com>
> > > Cc: Vinod Koul <vinod.koul@intel.com>
> > > Cc: Shawn Guo <shawn.guo@linaro.org>
> > > ---
> >
> > Acked-by: Shawn Guo <shawn.guo@linaro.org>
>
> Just to make sure: Did you investigate where the "abnormal" state came
> from and if that could be fixed?
>
I suppose this is a question for Aisheng, as he is the one who actually
saw the "abnormal" state. But since mxs_dma_disable_chan() is being
called in mxs_dma_control(DMA_TERMINATE_ALL) for case audio, it's should
be pretty safe reset the channel here.
--
Regards,
Shawn
next prev parent reply other threads:[~2011-07-19 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 4:09 [PATCH 1/1] ARM: mxs-dma: reset after disable channel Dong Aisheng
2011-07-19 4:02 ` Shawn Guo
2011-07-19 8:21 ` Wolfram Sang
2011-07-19 8:45 ` Shawn Guo [this message]
2011-07-19 9:13 ` Wolfram Sang
2011-07-19 9:20 ` Dong Aisheng-B29396
2011-07-19 13:44 ` Koul, Vinod
2011-07-25 14:25 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719084536.GH3838@S2100-06.ap.freescale.net \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox