From mboxrd@z Thu Jan 1 00:00:00 1970 From: w.sang@pengutronix.de (Wolfram Sang) Date: Tue, 19 Jul 2011 11:13:49 +0200 Subject: [PATCH 1/1] ARM: mxs-dma: reset after disable channel In-Reply-To: <20110719084536.GH3838@S2100-06.ap.freescale.net> References: <1311048596-19932-1-git-send-email-b29396@freescale.com> <20110719040215.GF3838@S2100-06.ap.freescale.net> <20110719082146.GA1951@pengutronix.de> <20110719084536.GH3838@S2100-06.ap.freescale.net> Message-ID: <20110719091349.GG1951@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jul 19, 2011 at 04:45:37PM +0800, Shawn Guo wrote: > On Tue, Jul 19, 2011 at 10:21:46AM +0200, Wolfram Sang wrote: > > On Tue, Jul 19, 2011 at 12:02:16PM +0800, Shawn Guo wrote: > > > On Tue, Jul 19, 2011 at 12:09:56PM +0800, Dong Aisheng wrote: > > > > We met some channels in abnormal state after disable. > > > > Reset it to get a clean state. > > > > > > > > Signed-off-by: Dong Aisheng > > > > Cc: Vinod Koul > > > > Cc: Shawn Guo > > > > --- > > > > > > Acked-by: Shawn Guo > > > > Just to make sure: Did you investigate where the "abnormal" state came > > from and if that could be fixed? > > > I suppose this is a question for Aisheng, as he is the one who actually > saw the "abnormal" state. OK. > But since mxs_dma_disable_chan() is being > called in mxs_dma_control(DMA_TERMINATE_ALL) for case audio, it's should > be pretty safe reset the channel here. It might be safe but can still hide the real bug ;) -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: