From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] gpio/mxc/mxs: fix build error introduced by the irq_gc_ack() renaming
Date: Tue, 19 Jul 2011 13:10:39 -0600 [thread overview]
Message-ID: <20110719191039.GC6848@ponder.secretlab.ca> (raw)
In-Reply-To: <1311081416-1251-1-git-send-email-shawn.guo@linaro.org>
On Tue, Jul 19, 2011 at 09:16:56PM +0800, Shawn Guo wrote:
> The following commit renames irq_gc_ack() to irq_gc_ack_set_bit(),
> and makes gpio-mxc and gpio-mxs fail to build.
>
> 659fb32d1b67476f4ade25e9ea0e2642a5b9c4b5
> genirq: replace irq_gc_ack() with {set,clr}_bit variants (fwd)
>
> The patch fixed a couple of typo of comma to semicolon.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Applied, thanks.
g.
> ---
> Changes since v1:
> * Fix a couple of typo of comma to semicolon
>
> drivers/gpio/gpio-mxc.c | 4 ++--
> drivers/gpio/gpio-mxs.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index 89fda58..4340aca 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -297,11 +297,11 @@ static void __init mxc_gpio_init_gc(struct mxc_gpio_port *port)
> gc->private = port;
>
> ct = gc->chip_types;
> - ct->chip.irq_ack = irq_gc_ack,
> + ct->chip.irq_ack = irq_gc_ack_set_bit;
> ct->chip.irq_mask = irq_gc_mask_clr_bit;
> ct->chip.irq_unmask = irq_gc_mask_set_bit;
> ct->chip.irq_set_type = gpio_set_irq_type;
> - ct->chip.irq_set_wake = gpio_set_wake_irq,
> + ct->chip.irq_set_wake = gpio_set_wake_irq;
> ct->regs.ack = GPIO_ISR;
> ct->regs.mask = GPIO_IMR;
>
> diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
> index d8cafba..af55a85 100644
> --- a/drivers/gpio/gpio-mxs.c
> +++ b/drivers/gpio/gpio-mxs.c
> @@ -156,11 +156,11 @@ static void __init mxs_gpio_init_gc(struct mxs_gpio_port *port)
> gc->private = port;
>
> ct = gc->chip_types;
> - ct->chip.irq_ack = irq_gc_ack,
> + ct->chip.irq_ack = irq_gc_ack_set_bit;
> ct->chip.irq_mask = irq_gc_mask_clr_bit;
> ct->chip.irq_unmask = irq_gc_mask_set_bit;
> ct->chip.irq_set_type = mxs_gpio_set_irq_type;
> - ct->chip.irq_set_wake = mxs_gpio_set_wake_irq,
> + ct->chip.irq_set_wake = mxs_gpio_set_wake_irq;
> ct->regs.ack = PINCTRL_IRQSTAT(port->id) + MXS_CLR;
> ct->regs.mask = PINCTRL_IRQEN(port->id);
>
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2011-07-19 19:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 3:34 [PATCH] gpio/mxc/mxs: fix build error introduced by the reanming of irq_gc_ack() Shawn Guo
2011-07-19 12:38 ` Sergei Shtylyov
2011-07-19 12:59 ` Shawn Guo
2011-07-19 15:23 ` Uwe Kleine-König
2011-07-19 13:16 ` [PATCH v2] gpio/mxc/mxs: fix build error introduced by the irq_gc_ack() renaming Shawn Guo
2011-07-19 19:10 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719191039.GC6848@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).