From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/dt: tegra devicetree support
Date: Wed, 20 Jul 2011 12:47:58 -0600 [thread overview]
Message-ID: <20110720184758.GG4642@ponder.secretlab.ca> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF049EBDEF01@HQMAIL01.nvidia.com>
On Wed, Jul 20, 2011 at 11:40:28AM -0700, Stephen Warren wrote:
> Grant Likely wrote at Wednesday, July 20, 2011 12:32 PM:
> > The compatible property here definitely represents the hardware
> > because it reflects the sound infrastructure on the harmony board.
>
> I can see that argument for "nvidia,harmony-sound".
>
> But "nvidia,tegra-wm8903" is pretty generic; I can certainly see there
> being Tegra 20 systems that use a WM8903 but are so different from either
> Harmony or anything supported by sound/soc/tegra/tegra_wm8903.c that the
> existing driver isn't applicable. And hence, there may be a different
> ASoC driver for such board(s), and hence choosing such a generic name as
> "tegra-wm8903" for Harmony/Seaboard's audio layout seems like it might
> cause problems in the future.
>
> I'm fine with such a generic name for the platform driver, since that name
> can fairly easily be modified just by editing the driver and the board file.
> But since *.dts files are at least logically separate from the kernel, such
> naming future-proofing is a little more important.
Sure, the tegra-wm8903 property can be dropped. If we start to see a
really well established pattern of the tegra paired with a wm8903,
then at that point we can define a compatible property for it and
document exactly what it means (document the boundaries and
assumptions that the compatible value requires).
g.
next prev parent reply other threads:[~2011-07-20 18:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 23:43 [PATCH] arm/dt: tegra devicetree support Grant Likely
2011-07-19 23:56 ` Olof Johansson
2011-07-20 18:56 ` Grant Likely
2011-07-20 15:37 ` Stephen Warren
2011-07-20 16:03 ` Mark Brown
2011-07-20 18:31 ` Grant Likely
2011-07-20 18:40 ` Stephen Warren
2011-07-20 18:47 ` Grant Likely [this message]
2011-07-20 19:49 ` Mark Brown
2011-07-20 18:28 ` Grant Likely
2011-07-20 18:33 ` Stephen Warren
2011-07-20 18:45 ` Grant Likely
2011-07-20 22:49 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110720184758.GG4642@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox