[patch 2/3] imx51: add pata clock

[patch 2/3] imx51: add pata clock

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efika_pata_add_clock.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110716/654b3c77/attachment.ksh>

[patch 0/3] imx: Efika: Add pata device

[Arnaud Patard (Rtp)]

This patchset is adding ressources, clock and device declarations for the
pata device available on imx51. Last patch enables pata on efika platforms.
To be complete, this patchset needs a driver, which is about to be sent for
merge to ata developers.

v2: created a imx51_add_mxc_pata() as suggested

Arnaud

[patch 1/3] imx51: add pata device

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efika_pata_add_dev.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110722/be54f3a6/attachment.ksh>

[patch 2/3] imx51: add pata clock

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efika_pata_add_clock.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110722/27043c1c/attachment.ksh>

[patch 3/3] imx: efika: Enable pata.

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efika_pata_enable_pata.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110722/e1d30763/attachment.ksh>

[patch 1/3] imx51: add pata device

[Fabio Estevam]

On Fri, Jul 22, 2011 at 7:37 AM, Arnaud Patard
<arnaud.patard@rtp-net.org> wrote:
...
> +#define imx_mxc_pata_data_entry_single(soc) ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> + ? ? ? { ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? \
> + ? ? ? ? ? ? ? .iobase = soc ## _ATA_BASE_ADDR, ? ? ? ? ? ? ? ? ? ? ? ?\
> + ? ? ? ? ? ? ? .irq = soc ## _MXC_INT_ATA, ? ? ? ? ? ? ? ? ? ? ? ? ? ? \

Why not imx_pata_data_entry_single instead?

 "imx_mxc" looks redundant.

Regards,

Fabio Estevam

[patch 1/3] imx51: add pata device

[Uwe Kleine-König]

On Fri, Jul 22, 2011 at 12:14:15PM -0300, Fabio Estevam wrote:
> On Fri, Jul 22, 2011 at 7:37 AM, Arnaud Patard
> <arnaud.patard@rtp-net.org> wrote:
> ...
> > +#define imx_mxc_pata_data_entry_single(soc) ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> > + ? ? ? { ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? \
> > + ? ? ? ? ? ? ? .iobase = soc ## _ATA_BASE_ADDR, ? ? ? ? ? ? ? ? ? ? ? ?\
> > + ? ? ? ? ? ? ? .irq = soc ## _MXC_INT_ATA, ? ? ? ? ? ? ? ? ? ? ? ? ? ? \
> 
> Why not imx_pata_data_entry_single instead?
> 
>  "imx_mxc" looks redundant.
imx is the platform prefix, mxc_pata the device's name. So IMHO the name
is right and consistent with the other device registration stuff.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[patch 1/3] imx51: add pata device

[Uwe Kleine-König]

Hello Arnaud,

On Fri, Jul 22, 2011 at 12:37:11PM +0200, Arnaud Patard wrote:
> +extern const struct imx_mxc_pata_data im51_mxc_pata_data;
imx51 please

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[patch 1/3] imx51: add pata device

[Arnaud Patard (Rtp)]

Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> writes:

> On Fri, Jul 22, 2011 at 12:14:15PM -0300, Fabio Estevam wrote:
>> On Fri, Jul 22, 2011 at 7:37 AM, Arnaud Patard
>> <arnaud.patard@rtp-net.org> wrote:
>> ...
>> > +#define imx_mxc_pata_data_entry_single(soc) ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
>> > + ? ? ? { ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? \
>> > + ? ? ? ? ? ? ? .iobase = soc ## _ATA_BASE_ADDR, ? ? ? ? ? ? ? ? ? ? ? ?\
>> > + ? ? ? ? ? ? ? .irq = soc ## _MXC_INT_ATA, ? ? ? ? ? ? ? ? ? ? ? ? ? ? \
>> 
>> Why not imx_pata_data_entry_single instead?
>> 
>>  "imx_mxc" looks redundant.
> imx is the platform prefix, mxc_pata the device's name. So IMHO the name
> is right and consistent with the other device registration stuff.

[patch 1/3] imx51: add pata device

[Uwe Kleine-König]

On Fri, Jul 22, 2011 at 10:28:49PM +0200, Arnaud Patard wrote:
> Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> writes:
> 
> > On Fri, Jul 22, 2011 at 12:14:15PM -0300, Fabio Estevam wrote:
> >> On Fri, Jul 22, 2011 at 7:37 AM, Arnaud Patard
> >> <arnaud.patard@rtp-net.org> wrote:
> >> ...
> >> > +#define imx_mxc_pata_data_entry_single(soc) ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
> >> > + ? ? ? { ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? \
> >> > + ? ? ? ? ? ? ? .iobase = soc ## _ATA_BASE_ADDR, ? ? ? ? ? ? ? ? ? ? ? ?\
> >> > + ? ? ? ? ? ? ? .irq = soc ## _MXC_INT_ATA, ? ? ? ? ? ? ? ? ? ? ? ? ? ? \
> >> 
> >> Why not imx_pata_data_entry_single instead?
> >> 
> >>  "imx_mxc" looks redundant.
> > imx is the platform prefix, mxc_pata the device's name. So IMHO the name
> > is right and consistent with the other device registration stuff.
> 
> From looking at devices-imx51.h, I don't see no obvious consistant
> naming scheme :
> 
> extern const struct imx_fec_data imx51_fec_data;
driver name: fec
> ...
> extern const struct imx_imx_i2c_data imx51_imx_i2c_data[];
driver name: imx_i2c
> ...
> extern const struct imx_mxc_nand_data imx51_mxc_nand_data;
driver name: mxc_nand
> ...
> extern const struct imx_spi_imx_data imx51_cspi_data;
driver name: spi_imx

So the driver names are not consistent, ok. But the names used in
devices-imx51.h match these. It's always imx_${drivername}_data.

> So, I can use either imx_pata_data or keep imx_mxc_pata_data or
> imx_imx_pata_data or imx_pata_imx_data. What do you both prefer ?
So if your driver is called "mxc_pata", please use
imx_mxc_pata_data_entry_single.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[patch 2/3] imx51: add pata clock

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efika_pata_add_clock.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110724/90469113/attachment.ksh>

[patch 2/3] imx51: add pata clock

[Sascha Hauer]

On Sun, Jul 24, 2011 at 08:39:04PM +0200, Arnaud Patard wrote:
> Define the clock used by the imx51 pata device.
> 
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> 
> 
> Index: linux-2.6-submit/arch/arm/mach-mx5/clock-mx51-mx53.c
> ===================================================================
> --- linux-2.6-submit.orig/arch/arm/mach-mx5/clock-mx51-mx53.c	2011-07-22 23:29:09.000000000 +0200
> +++ linux-2.6-submit/arch/arm/mach-mx5/clock-mx51-mx53.c	2011-07-24 20:35:17.000000000 +0200
> @@ -1414,6 +1414,10 @@ DEFINE_CLOCK(ipu_di0_clk, 0, MXC_CCM_CCG
>  DEFINE_CLOCK(ipu_di1_clk, 0, MXC_CCM_CCGR6, MXC_CCM_CCGRx_CG6_OFFSET,
>  		NULL, NULL, &pll3_sw_clk, NULL);
>  
> +/* PATA */
> +DEFINE_CLOCK(pata_clk, 0, MXC_CCM_CCGR4, MXC_CCM_CCGRx_CG0_OFFSET,
> +		NULL, NULL, &ipg_clk, &spba_clk);
> +
>  #define _REGISTER_CLOCK(d, n, c) \
>         { \
>  		.dev_id = d, \
> @@ -1466,6 +1470,7 @@ static struct clk_lookup mx51_lookups[]
>  	_REGISTER_CLOCK("imx-ipuv3", "di0", ipu_di0_clk)
>  	_REGISTER_CLOCK("imx-ipuv3", "di1", ipu_di1_clk)
>  	_REGISTER_CLOCK(NULL, "gpc_dvfs", gpc_dvfs_clk)
> +	_REGISTER_CLOCK("imx-pata", NULL, pata_clk)

First argument to _REGISTER_CLOCK must match the device name, but the
driver you posted uses pata_imx as device name. The second argument
which you correctly set to NULL here is an additional identifier which
must match if it exists. There is only one clock in the pata driver, so
you should use clk_get(&pdev->dev, NULL) in you driver.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[patch 2/3] imx51: add pata clock

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efika_pata_add_clock.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110726/0a0332b3/attachment.ksh>