From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3.0] fix compile warnings in plat-iop/cp6.c
Date: Fri, 22 Jul 2011 14:27:21 +0100 [thread overview]
Message-ID: <20110722132721.GA25947@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20009.28803.497535.598471@pilspetsen.it.uu.se>
On Fri, Jul 22, 2011 at 02:43:47PM +0200, Mikael Pettersson wrote:
> Building 3.0 for an n2100 (plat-iop) results in:
>
> In file included from arch/arm/plat-iop/cp6.c:20:
> /tmp/linux-3.0/arch/arm/include/asm/traps.h:12: warning: 'struct pt_regs' declared inside parameter list
> /tmp/linux-3.0/arch/arm/include/asm/traps.h:12: warning: its scope is only this definition or declaration, which is probably not what you want
> /tmp/linux-3.0/arch/arm/include/asm/traps.h:48: warning: 'struct pt_regs' declared inside parameter list
> /tmp/linux-3.0/arch/arm/include/asm/traps.h:48: warning: 'struct task_struct' declared inside parameter list
> arch/arm/plat-iop/cp6.c:45: warning: initialization from incompatible pointer type
>
> The pt_regs and incompatible pointer type warnings are fixed by including
> <asm/ptrace.h> before <asm/traps.h>. Nothing here depends on task_struct,
> so that warning can be fixed by a forward struct declaration.
Why not add a forward declaration of struct pt_regs and task_struct
to asm/traps.h ?
next prev parent reply other threads:[~2011-07-22 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 12:43 [PATCH 3.0] fix compile warnings in plat-iop/cp6.c Mikael Pettersson
2011-07-22 13:27 ` Russell King - ARM Linux [this message]
2011-07-22 14:28 ` Mikael Pettersson
2011-07-22 15:07 ` Russell King - ARM Linux
2011-07-22 16:01 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110722132721.GA25947@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox