* [PATCH] arm: exynos4: Fix write to nonexistent TCMPB4 PWM register on samsung exynos4 platform
@ 2011-07-27 3:27 Kyungmin Park
2011-07-27 12:30 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Kyungmin Park @ 2011-07-27 3:27 UTC (permalink / raw)
To: linux-arm-kernel
From: Evgeny Voevodin <e.voevodin@samsung.com>
There is no TCMPB register for Pulse Width Modulation timer4 on samsung exynos4 board. Remove unsupported register write.
Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/mach-exynos4/time.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-exynos4/time.c b/arch/arm/mach-exynos4/time.c
index 86b9fa0..48389bf 100644
--- a/arch/arm/mach-exynos4/time.c
+++ b/arch/arm/mach-exynos4/time.c
@@ -77,7 +77,6 @@ static void exynos4_pwm_init(unsigned int pwm_id, unsigned long tcnt)
tcon |= S3C2410_TCON_T4MANUALUPD;
__raw_writel(tcnt, S3C2410_TCNTB(4));
- __raw_writel(tcnt, S3C2410_TCMPB(4));
__raw_writel(tcon, S3C2410_TCON);
break;
--
1.7.4.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm: exynos4: Fix write to nonexistent TCMPB4 PWM register on samsung exynos4 platform
2011-07-27 3:27 [PATCH] arm: exynos4: Fix write to nonexistent TCMPB4 PWM register on samsung exynos4 platform Kyungmin Park
@ 2011-07-27 12:30 ` Sergei Shtylyov
2011-07-28 6:20 ` Evgeny Voevodin
2011-08-12 9:36 ` Kukjin Kim
0 siblings, 2 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2011-07-27 12:30 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 27-07-2011 7:27, Kyungmin Park wrote:
> From: Evgeny Voevodin<e.voevodin@samsung.com>
> There is no TCMPB register for Pulse Width Modulation timer4 on samsung exynos4 board. Remove unsupported register write.
> Signed-off-by: Evgeny Voevodin<e.voevodin@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> ---
> arch/arm/mach-exynos4/time.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
> diff --git a/arch/arm/mach-exynos4/time.c b/arch/arm/mach-exynos4/time.c
> index 86b9fa0..48389bf 100644
> --- a/arch/arm/mach-exynos4/time.c
> +++ b/arch/arm/mach-exynos4/time.c
> @@ -77,7 +77,6 @@ static void exynos4_pwm_init(unsigned int pwm_id, unsigned long tcnt)
>
> tcon |= S3C2410_TCON_T4MANUALUPD;
>
>
>
> __raw_writel(tcnt, S3C2410_TCNTB(4));
>
> - __raw_writel(tcnt, S3C2410_TCMPB(4));
>
> __raw_writel(tcon, S3C2410_TCON);
>
>
>
> break;
>
Looks like the patch was spolied by something -- the extra new lines were
added after each line.
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm: exynos4: Fix write to nonexistent TCMPB4 PWM register on samsung exynos4 platform
2011-07-27 12:30 ` Sergei Shtylyov
@ 2011-07-28 6:20 ` Evgeny Voevodin
2011-08-12 9:36 ` Kukjin Kim
1 sibling, 0 replies; 4+ messages in thread
From: Evgeny Voevodin @ 2011-07-28 6:20 UTC (permalink / raw)
To: linux-arm-kernel
From: Evgeny Voevodin <e.voevodin@samsung.com>
There is no TCMPB register for Pulse Width Modulation timer4 on samsung
exynos4 board. Remove unsupported register write.
Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
---
arch/arm/mach-exynos4/time.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-exynos4/time.c b/arch/arm/mach-exynos4/time.c
index 86b9fa0..48389bf 100644
--- a/arch/arm/mach-exynos4/time.c
+++ b/arch/arm/mach-exynos4/time.c
@@ -77,7 +77,6 @@ static void exynos4_pwm_init(unsigned int pwm_id,
unsigned long tcnt)
tcon |= S3C2410_TCON_T4MANUALUPD;
__raw_writel(tcnt, S3C2410_TCNTB(4));
- __raw_writel(tcnt, S3C2410_TCMPB(4));
__raw_writel(tcon, S3C2410_TCON);
break;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] arm: exynos4: Fix write to nonexistent TCMPB4 PWM register on samsung exynos4 platform
2011-07-27 12:30 ` Sergei Shtylyov
2011-07-28 6:20 ` Evgeny Voevodin
@ 2011-08-12 9:36 ` Kukjin Kim
1 sibling, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2011-08-12 9:36 UTC (permalink / raw)
To: linux-arm-kernel
Sergei Shtylyov wrote:
>
> Hello.
>
> On 27-07-2011 7:27, Kyungmin Park wrote:
>
> > From: Evgeny Voevodin<e.voevodin@samsung.com>
>
>
>
> > There is no TCMPB register for Pulse Width Modulation timer4 on samsung
> exynos4 board. Remove unsupported register write.
>
>
>
> > Signed-off-by: Evgeny Voevodin<e.voevodin@samsung.com>
>
> > Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>
> > ---
>
> > arch/arm/mach-exynos4/time.c | 1 -
>
> > 1 files changed, 0 insertions(+), 1 deletions(-)
>
>
>
> > diff --git a/arch/arm/mach-exynos4/time.c b/arch/arm/mach-exynos4/time.c
>
> > index 86b9fa0..48389bf 100644
>
> > --- a/arch/arm/mach-exynos4/time.c
>
> > +++ b/arch/arm/mach-exynos4/time.c
>
> > @@ -77,7 +77,6 @@ static void exynos4_pwm_init(unsigned int pwm_id,
> unsigned long tcnt)
> >
> > tcon |= S3C2410_TCON_T4MANUALUPD;
> >
> >
> >
> > __raw_writel(tcnt, S3C2410_TCNTB(4));
> >
> > - __raw_writel(tcnt, S3C2410_TCMPB(4));
> >
> > __raw_writel(tcon, S3C2410_TCON);
> >
> >
> >
> > break;
> >
>
> Looks like the patch was spolied by something -- the extra new lines
were
> added after each line.
>
Thanks, Sergei.
And this is not available now...
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-12 9:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-27 3:27 [PATCH] arm: exynos4: Fix write to nonexistent TCMPB4 PWM register on samsung exynos4 platform Kyungmin Park
2011-07-27 12:30 ` Sergei Shtylyov
2011-07-28 6:20 ` Evgeny Voevodin
2011-08-12 9:36 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).