From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] DMA: PL330: Update PL330 DMAC to support runtime PM
Date: Wed, 27 Jul 2011 09:53:48 +0100 [thread overview]
Message-ID: <20110727085348.GB21584@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4E2FACC3.2010109@samsung.com>
On Wed, Jul 27, 2011 at 03:14:27PM +0900, Chanwoo Choi wrote:
> +#ifdef CONFIG_PM_RUNTIME
> + struct dma_pl330_chan *pch;
> + struct dma_pl330_dmac *pdmac;
> +#endif
>
> dma_cap_zero(mask);
> dma_cap_set(info->cap, mask);
>
> chan = dma_request_channel(mask, pl330_filter, (void *)dma_ch);
>
> +#ifdef CONFIG_PM_RUNTIME
> + pch = container_of(chan, struct dma_pl330_chan, chan);
> + pdmac = pch->dmac;
> +
> + pm_runtime_get_sync(pdmac->pif.dev);
> +#endif
This is not the right way to do this. The pm runtime stuff should be
internal to the PL330 driver. Take a moment to think about this:
You need to wake it up just before a transfer starts. You need to
put it back to sleep just after the last transfer has finished.
That gives you a hint where the calls need to be.
That can only be done from within the PL330 driver.
next prev parent reply other threads:[~2011-07-27 8:53 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 5:31 [PATCH V5 00/15] To use DMA generic APIs for Samsung DMA Boojin Kim
2011-07-27 5:31 ` [PATCH 01/15] DMA: PL330: Add support runtime PM for PL330 DMAC Boojin Kim
2011-07-27 6:14 ` [RFC PATCH] DMA: PL330: Update PL330 DMAC to support runtime PM Chanwoo Choi
2011-07-27 7:31 ` Jassi Brar
2011-07-27 8:53 ` Russell King - ARM Linux [this message]
2011-07-27 9:43 ` Chanwoo Choi
2011-07-27 7:43 ` [PATCH 01/15] DMA: PL330: Add support runtime PM for PL330 DMAC Jassi Brar
2011-07-27 5:31 ` [PATCH 02/15] DMA: PL330: Update PL330 DMA API driver Boojin Kim
2011-07-27 5:31 ` [PATCH 03/15] DMA: PL330: Support DMA_SLAVE_CONFIG command Boojin Kim
2011-07-27 5:31 ` [PATCH 04/15] DMA: PL330: Add DMA_CYCLIC capability Boojin Kim
2011-07-27 5:31 ` [PATCH 05/15] ARM: SAMSUNG: Update to use PL330-DMA driver Boojin Kim
2011-07-27 5:31 ` [PATCH 06/15] ARM: SAMSUNG: Add common DMA operations Boojin Kim
2011-07-27 5:31 ` [PATCH 07/15] ARM: EXYNOS4: Use generic DMA PL330 driver Boojin Kim
2011-08-15 9:36 ` Thomas Abraham
2011-08-15 14:15 ` Thomas Abraham
2011-08-21 8:51 ` Russell King - ARM Linux
2011-07-27 5:31 ` [PATCH 08/15] ARM: S5PV210: " Boojin Kim
2011-07-27 5:31 ` [PATCH 09/15] ARM: S5PC100: " Boojin Kim
2011-07-27 5:31 ` [PATCH 10/15] ARM: S5P64X0: " Boojin Kim
2011-07-27 5:31 ` [PATCH 11/15] ARM: SAMSUNG: Remove S3C-PL330-DMA driver Boojin Kim
2011-07-27 5:31 ` [PATCH 12/15] spi/s3c64xx: Add support DMA engine API Boojin Kim
2011-08-08 17:47 ` Jassi Brar
2011-08-08 17:55 ` Heiko Stübner
2011-08-08 18:16 ` Jassi Brar
2011-08-08 18:26 ` Heiko Stübner
2011-08-09 4:13 ` Alim Akhtar
2011-08-19 10:30 ` Alim Akhtar
2011-08-21 8:46 ` Russell King - ARM Linux
2011-08-25 1:13 ` Alim Akhtar
2011-08-11 7:42 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 13/15] spi/s3c64xx: Merge dma control code Boojin Kim
2011-08-08 18:32 ` Jassi Brar
2011-07-27 5:31 ` [PATCH 14/15] ASoC: Samsung: Update DMA interface Boojin Kim
2011-08-08 19:27 ` Jassi Brar
2011-08-11 10:04 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 15/15] ARM: SAMSUNG: Remove Samsung specific enum type for dma direction Boojin Kim
2011-08-04 16:53 ` [PATCH V5 00/15] To use DMA generic APIs for Samsung DMA Linus Walleij
2011-08-08 16:45 ` Koul, Vinod
2011-08-11 7:26 ` Kukjin Kim
2011-08-11 22:27 ` Koul, Vinod
2011-08-13 4:11 ` Kukjin Kim
2011-08-16 11:01 ` Koul, Vinod
2011-08-19 5:24 ` Kukjin Kim
2011-08-19 13:04 ` Koul, Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727085348.GB21584@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).