From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] arch: arm: mach-cns3xxx: Add gpiolib support
Date: Thu, 28 Jul 2011 11:04:44 +0100 [thread overview]
Message-ID: <20110728100444.GC31473@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1311873401-26075-1-git-send-email-tommy.lin.1101@gmail.com>
On Fri, Jul 29, 2011 at 01:16:41AM +0800, Tommy Lin wrote:
> +#include <linux/platform_device.h>
> +#include <linux/proc_fs.h>
> +#include <linux/io.h>
> +
> +#include <mach/gpio.h>
Come on guys, you absolutely deserve your code to break as you're
continuing to include mach/gpio.h directly, even after I've said
I'm going to be moving stuff out of mach/gpio.h into asm/gpio.h...
> +#include <asm-generic/gpio.h>
> +
> +#define gpio_get_value __gpio_get_value
> +#define gpio_set_value __gpio_set_value
> +#define gpio_cansleep __gpio_cansleep
> +#define gpio_to_irq __gpio_to_irq
Oh look, yet another identical implementation to add to the list...
(it's this stuff which I'm moving after this merge window.)
Please, make sure you include linux/gpio.h and not mach/gpio.h.
next prev parent reply other threads:[~2011-07-28 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 17:16 [PATCH 2/3] arch: arm: mach-cns3xxx: Add gpiolib support Tommy Lin
2011-07-28 10:04 ` Russell King - ARM Linux [this message]
2011-07-28 10:15 ` Jamie Iles
2011-07-28 12:13 ` 林宏文
2011-07-28 12:51 ` Felipe Balbi
2011-07-28 13:19 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728100444.GC31473@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).