From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] arch: arm: mach-cns3xxx: Add external interrupt pin demo program
Date: Thu, 28 Jul 2011 11:06:48 +0100 [thread overview]
Message-ID: <20110728100648.GD31473@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1311873475-26111-1-git-send-email-tommy.lin.1101@gmail.com>
On Fri, Jul 29, 2011 at 01:17:55AM +0800, Tommy Lin wrote:
> +#include <mach/gpio.h>
Need I mention it...
> +static irqreturn_t cns3xxx_ext_intr1_handler(int irq, void *dev_id)
> +{
> + int value;
> +
> + value = gpio_get_value(led_D6);
> +
> + disable_irq_nosync(irq);
> +
> + gpio_set_value(led_D6, !value);
> +
> + enable_irq(irq);
Why do you need the disable_irq/enable_irq ? The interrupt you're
dealing with will already be masked by the core genirq code.
prev parent reply other threads:[~2011-07-28 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 17:17 [PATCH 3/3] arch: arm: mach-cns3xxx: Add external interrupt pin demo program Tommy Lin
2011-07-28 10:06 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728100648.GD31473@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).