From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/6] ARM: mxs: add usb phy operations
Date: Thu, 28 Jul 2011 12:27:02 +0100 [thread overview]
Message-ID: <20110728112702.GE31473@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110727080315.GN20587@pengutronix.de>
On Wed, Jul 27, 2011 at 10:03:15AM +0200, Sascha Hauer wrote:
> On Wed, Jul 27, 2011 at 01:29:33PM +0800, Tony Lin wrote:
> > + if (!ppriv->phy_regs || !ppriv->ctrl_regs) {
> > + iounmap(ppriv->phy_regs);
> > + iounmap(ppriv->ctrl_regs);
> > + return -ENOMEM;
> > + }
>
> So you call iounmap(0) here.
That is not a problem. iounmap() is like kfree(). It's designed to cope
with NULL.
next prev parent reply other threads:[~2011-07-28 11:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 5:29 [PATCH v3 0/6] ARM: mx28: add usb host function Tony Lin
2011-07-27 5:29 ` [PATCH v3 1/6] ARM: mxs: ehci: consolidate definitions and structures to share among platforms Tony Lin
2011-07-27 5:29 ` [PATCH v3 2/6] ARM: mxs: enable usb1 phy power supply Tony Lin
2011-07-27 5:29 ` [PATCH v3 3/6] ARM: mxs: add usb clocks to clock tree Tony Lin
2011-07-27 5:29 ` [PATCH v3 4/6] ARM: mxs: make ehci-mxc more flexible to be used on different platforms Tony Lin
2011-07-27 8:19 ` Marc Kleine-Budde
2011-07-27 5:29 ` [PATCH v3 5/6] ARM: mxs: add usb phy operations Tony Lin
2011-07-27 8:03 ` Sascha Hauer
2011-07-27 8:16 ` Lin Tony-B19295
2011-07-28 7:39 ` Lin Tony-B19295
2011-07-28 11:27 ` Russell King - ARM Linux [this message]
2011-07-27 8:48 ` Lothar Waßmann
2011-07-27 9:10 ` Lin Tony-B19295
2011-07-27 9:24 ` Lothar Waßmann
2011-07-27 8:57 ` Marc Kleine-Budde
2011-07-27 5:29 ` [PATCH v3 6/6] ARM: mxs: add usb host function to default config Tony Lin
2011-07-27 9:01 ` [PATCH v3 0/6] ARM: mx28: add usb host function Marc Kleine-Budde
2011-07-27 9:15 ` Lin Tony-B19295
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728112702.GE31473@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).