From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Add sched_clock to AT91 TCB clocksource driver
Date: Mon, 1 Aug 2011 10:28:06 +0100 [thread overview]
Message-ID: <20110801092806.GD15578@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CANqCtQJwUsLXfA408GzAr0rQtc2DRjtKqP8-m2UBUGEy-YP5dg@mail.gmail.com>
On Mon, Aug 01, 2011 at 10:42:35AM +0200, Remy Bohmer wrote:
> OK, I know that too, but the jiffies based fallback does it even
> worse, since it does not run at all... (It only updates in steps of a
> couple of 100msecs and stops after a while, and even does not display
> a real time...) This sched_clock implementation at least works before
> the drivers are being initialised...
You're forgetting that jiffies doesn't jump about. A late initializing
sched_clock could jump.
> Anyway, do you have a better suggestion how to fix this? The tcb
> clocksource is loaded during a arch_initcall(), perhaps we need
> something before that point.
> I do not see an easy way to integrate it in MACHINE_START(.timer).
> Would 'late_time_init' be a better solution?
late_time_init() is not that much better as that still happens after
sched_init() has been called. sched_init() initializes various
structures which involves reading sched_clock().
Why can't it initialize itself at the standard point during the boot
sequence, which is time_init() - which in turn is as you say the
.timer callback?
next prev parent reply other threads:[~2011-08-01 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-31 15:03 [PATCH] Add sched_clock to AT91 TCB clocksource driver Remy Bohmer
2011-07-31 15:07 ` Russell King - ARM Linux
2011-08-01 8:42 ` Remy Bohmer
2011-08-01 9:28 ` Russell King - ARM Linux [this message]
2011-08-01 18:08 ` Remy Bohmer
2011-08-01 19:48 ` Russell King - ARM Linux
2011-08-01 20:00 ` Remy Bohmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110801092806.GD15578@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox