From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Remove remaining references of CONFIG_GENERIC_TIME
Date: Mon, 1 Aug 2011 15:25:22 +0100 [thread overview]
Message-ID: <20110801142522.GC19079@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAGVye5Nh2E4L3Ox=OKvG09v4hO6BjGmLUGZ5=Ha2QzbXar+deA@mail.gmail.com>
On Mon, Aug 01, 2011 at 01:41:32PM +0200, Zoltan Devai wrote:
> 2011/8/1 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> > On Sat, Jul 30, 2011 at 06:14:38PM +0200, Zoltan Devai wrote:
> >> Commit 592913ecb87a9e06f98ddb55b298f1a66bf94c6b has killed off any
> >> use of this config option long ago.
> >
> > I don't see the point of this - we were free of GENERIC_TIME on ARM
> > shortly after it was originally killed off. ?The problem is you can't
> > stop people introducing new uses of this - because it existed once and
> > there's nothing which errors out on its presence, people are going to
> > continue submitting patches with it in. ?And it's going to continue
> > being missed at the review stage.
> >
> > I've a similar problem with folk on ARM including mach/gpio.h as their
> > sole gpio header file rather than linux/gpio.h - I've been trying for
> > the last 1-2 years to educate people to use linux/ in preference. ?You
> > can't do it, and I'm still just about the only one who picks up on that.
> > (SoC maintainers don't care.) ?They will end up caring when I push a
> > change during the next merge window though, so I'll eventually stop
> > mach/gpio.h being included. ?(Instead, it'll be asm/gpio.h).
> >
> > GENERIC_TIME though... I don't think you'll ever stop new uses of it
> > creeping in unless you can arrange for something to error out.
>
> Sure, but the patch at least reduces the chances of copy-pasting it,
> and makes it obvious by a simple grep that there's no use of it at all,
> so I still think it's wort merging.
That argument doesn't work - as can be seen from my first paragraph.
The fact that we have new references to it in arch/arm/Kconfig is
proof of that.
prev parent reply other threads:[~2011-08-01 14:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-30 16:14 [PATCH] Remove remaining references of CONFIG_GENERIC_TIME Zoltan Devai
2011-07-30 16:33 ` Sergei Shtylyov
2011-07-30 16:41 ` richard -rw- weinberger
2011-08-01 8:36 ` Russell King - ARM Linux
2011-08-01 10:09 ` Geert Uytterhoeven
2011-08-01 10:14 ` Russell King - ARM Linux
2011-08-01 11:27 ` Geert Uytterhoeven
2011-08-01 14:36 ` Uwe Kleine-König
2011-08-01 15:04 ` Arnaud Lacombe
2011-08-01 15:15 ` Kyle Moffett
2011-08-01 16:08 ` Arnaud Lacombe
2011-08-01 16:40 ` Nicolas Pitre
2011-08-01 17:20 ` Arnaud Lacombe
2011-08-01 16:48 ` Kyle Moffett
2011-08-01 17:14 ` Arnaud Lacombe
2011-08-01 17:15 ` Arnaud Lacombe
2011-08-01 11:41 ` Zoltan Devai
2011-08-01 14:25 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110801142522.GC19079@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).