linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] arm/mx5: add device tree support for imx53 boards
Date: Tue, 2 Aug 2011 14:40:30 +0100	[thread overview]
Message-ID: <20110802134030.GA20071@ponder.secretlab.ca> (raw)
In-Reply-To: <20110802060936.GA9972@freescale.com>

On Tue, Aug 02, 2011 at 02:09:37PM +0800, Shawn Guo wrote:
> On Mon, Aug 01, 2011 at 11:01:39PM +0100, Grant Likely wrote:
> > On Mon, Aug 1, 2011 at 8:17 PM, Shawn Guo <shawn.guo@linaro.org> wrote:
> > However, today when we were talking you asked if it would be better to
> > use a callback into board-specific code instead of the iomux table
> > that is implemented in this patch.  I was fine either way, but my
> > opinion was that the table would probably result in less code.  Well,
> > combined with the above problem, I think I was wrong.  Since the only
> > difference in the ard variant is the call to
> > imx53_ard_weim_cs_config(), both the cs config and the iomux setup
> > will be simpler if both are handled in a callback.  You're original
> > instinct was correct.
> > 
> 
> Ok, here you go.

Yes, I think this is the right approach.  Go ahead and spin it into a
real patch series and repost.

Acked-by: Grant Likely <grant.likely@secretlab.ca>

g.

  reply	other threads:[~2011-08-02 13:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-01 19:17 [PATCH v3 0/3] Add device tree support for i.mx51/53 boards Shawn Guo
2011-08-01 19:17 ` [PATCH v3 1/2] arm/mx5: add device tree support for imx53 boards Shawn Guo
2011-08-01 22:01   ` Grant Likely
2011-08-02  6:09     ` Shawn Guo
2011-08-02 13:40       ` Grant Likely [this message]
2011-08-02  6:58   ` Sascha Hauer
2011-08-02  1:22     ` Shawn Guo
2011-08-02  7:53     ` Shawn Guo
2011-08-02 11:43     ` Grant Likely
2011-08-01 19:17 ` [PATCH v3 2/2] arm/mx5: add device tree support for imx51 babbage Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110802134030.GA20071@ponder.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).