From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ASoC: core: cache index fix
Date: Wed, 3 Aug 2011 00:27:13 +0900 [thread overview]
Message-ID: <20110802152712.GC25884@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <65EE16ACC360FA4D99C96DC085B3F7721F4616@039-SN1MPN1-002.039d.mgd.msft.net>
On Tue, Aug 02, 2011 at 01:17:12PM +0000, Dong Aisheng-B29396 wrote:
> For rbtree, i tried that only changed snd_soc_rbtree_cache_init as follows
> Could work. Then rbtree_cache_read/write do not need to care about step.
> This could reduce many code changes and complexity.
> But the disadvantage is that the rbtree cache may not be able to find a
> adjacent register in the same block if the reg step is 2.
> However it works.
> Do you think this is acceptable?
No, like I've been saying the rbtree should have *no* visibility of step
sizes. This is exactly the sort of complexity and fragility that I've
been raising as an issue.
next prev parent reply other threads:[~2011-08-02 15:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 11:38 [PATCH 1/1] ASoC: core: cache index fix Dong Aisheng
2011-08-01 11:51 ` Mark Brown
2011-08-02 8:03 ` Dong Aisheng-B29396
2011-08-02 8:38 ` Mark Brown
2011-08-02 9:41 ` Dong Aisheng-B29396
2011-08-02 10:34 ` [alsa-devel] " Takashi Iwai
2011-08-02 10:55 ` Dong Aisheng-B29396
2011-08-02 11:09 ` Takashi Iwai
2011-08-02 11:15 ` Dong Aisheng-B29396
2011-08-02 12:10 ` Takashi Iwai
2011-08-02 12:29 ` Dong Aisheng-B29396
2011-08-02 12:52 ` Takashi Iwai
2011-08-02 15:48 ` Mark Brown
2011-08-02 16:13 ` Takashi Iwai
2011-08-02 16:40 ` Mark Brown
2011-08-02 18:06 ` Takashi Iwai
2011-08-03 5:23 ` Mark Brown
2011-08-03 6:20 ` Takashi Iwai
2011-08-03 9:00 ` Mark Brown
2011-08-03 7:03 ` Dong Aisheng-B29396
2011-08-03 7:39 ` Dong Aisheng-B29396
2011-08-03 9:31 ` Mark Brown
2011-08-03 11:11 ` Dong Aisheng-B29396
2011-08-02 12:58 ` Mark Brown
2011-08-02 13:17 ` Dong Aisheng-B29396
2011-08-02 15:27 ` Mark Brown [this message]
2011-08-02 16:05 ` Mark Brown
2011-08-02 9:51 ` Wolfram Sang
2011-08-02 10:38 ` [alsa-devel] " Takashi Iwai
2011-08-02 15:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110802152712.GC25884@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).