linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mach-davinci: fix cache flush build error
Date: Tue, 2 Aug 2011 17:02:34 +0100	[thread overview]
Message-ID: <20110802160234.GH19079@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1312300118-9088-1-git-send-email-linus.walleij@stericsson.com>

On Tue, Aug 02, 2011 at 05:48:38PM +0200, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
> 
> The TNET variant of DaVinci compiles some code that it shares
> with other DaVinci variants, however it has a V6 CPU rather than
> an ARM926T, thus the hardcoded call to arm926_flush_kern_cache_all()
> in sleep.S will obviously fail, and we need to build with the
> v6_flush_kern_cache_all() call instead. This was triggered by
> manually altering the DaVinci config to build the TNET version.
> 
> Cc: Dave Martin <dave.martin@linaro.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> This is just an ifdef to get the DaVinci TNET variant to compile,
> if there is a way to call out to some abstract flush function in a
> MULTI CPU/cache configuration from _assembler_ code, please tell me,
> 
> I'm not all that happy about this since it blocks proper multiboard
> support for DaVinci, would be nice to find a better solution.

Davinci seems to be a special case where it somehow preserves all state
even in deep sleep, which makes the generic cpu_suspend() not ideal for
it.

Or maybe that's just an oversight in the existing code - I don't know
so I haven't touched it.  I've been hoping that Davinci people can sort
it out...

  reply	other threads:[~2011-08-02 16:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02 15:48 [PATCH] mach-davinci: fix cache flush build error Linus Walleij
2011-08-02 16:02 ` Russell King - ARM Linux [this message]
2011-08-03 17:19   ` Nori, Sekhar
2011-08-03 18:14     ` Russell King - ARM Linux
2011-08-03 22:48     ` Linus Walleij
2011-08-04 14:30       ` Nori, Sekhar
2011-08-03 13:23 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110802160234.GH19079@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).