From: ben@trinity.fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] mmc: at91_mci: remove the use of irq_to_gpio
Date: Fri, 5 Aug 2011 09:58:13 +0100 [thread overview]
Message-ID: <20110805085813.GK13248@trinity.fluff.org> (raw)
In-Reply-To: <1312472943-13839-1-git-send-email-nicolas.ferre@atmel.com>
On Thu, Aug 04, 2011 at 04:49:03PM +0100, Nicolas Ferre wrote:
> Remove the use of irq_to_gpio() in the card detection interrupt
> handler. The information is available in the board structure and
> we can avoid using a function that has little meaning.
thanks, looks good.
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> Ben, Arnd,
>
> I have identified this use of irq_to_gpio() which can be remove immediatly.
>
> drivers/mmc/host/at91_mci.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/at91_mci.c b/drivers/mmc/host/at91_mci.c
> index a4aa3af..351951c 100644
> --- a/drivers/mmc/host/at91_mci.c
> +++ b/drivers/mmc/host/at91_mci.c
> @@ -869,7 +869,10 @@ static irqreturn_t at91_mci_irq(int irq, void *devid)
> static irqreturn_t at91_mmc_det_irq(int irq, void *_host)
> {
> struct at91mci_host *host = _host;
> - int present = !gpio_get_value(irq_to_gpio(irq));
> + int present;
> +
> + /* if we are here is that the det_pin exists */
> + present = !gpio_get_value(host->board->det_pin);
>
> /*
> * we expect this irq on both insert and remove,
> --
> 1.7.4.1
>
--
Ben Dooks, ben at fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
next prev parent reply other threads:[~2011-08-05 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 15:49 [RFC PATCH] mmc: at91_mci: remove the use of irq_to_gpio Nicolas Ferre
2011-08-04 16:47 ` Sergei Shtylyov
2011-08-05 8:58 ` Ben Dooks [this message]
2011-08-05 15:18 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110805085813.GK13248@trinity.fluff.org \
--to=ben@trinity.fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).