From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: OMAP3 kernels fail to build
Date: Mon, 8 Aug 2011 12:00:56 +0100 [thread overview]
Message-ID: <20110808110056.GA15134@n2100.arm.linux.org.uk> (raw)
With CONFIG_ARCH_OMAP3=y and CONFIG_ARCH_OMAP4=n, I'm getting this:
arch/arm/mach-omap2/built-in.o:(.data+0xf99c): undefined reference to `omap4430_phy_init'
arch/arm/mach-omap2/built-in.o:(.data+0xf9a0): undefined reference to `omap4430_phy_exit'
arch/arm/mach-omap2/built-in.o:(.data+0xf9a4): undefined reference to `omap4430_phy_power'
arch/arm/mach-omap2/built-in.o:(.data+0xf9a8): undefined reference to `omap4430_phy_set_clk'
arch/arm/mach-omap2/built-in.o:(.data+0xf9ac): undefined reference to `omap4430_phy_suspend'
This is probably from twl-common.c, which doesn't really look very
common to me (looks like some is specific to OMAP3 and the rest is
OMAP4 specific.)
As this is always built for all OMAP2+, this will also break OMAP2 as
well. Why it's even built on OMAP2, I've no idea.
I think the OMAP3 specific bits should be separate from the OMAP4
specific bits, which should be separate from the small amount of
common stuff.
Please either fix ASAP, or revert the five changes for twl-common.c
next reply other threads:[~2011-08-08 11:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 11:00 Russell King - ARM Linux [this message]
2011-08-08 11:09 ` OMAP3 kernels fail to build Santosh
2011-08-08 11:30 ` Russell King - ARM Linux
2011-08-09 13:16 ` Tony Lindgren
2011-08-10 5:26 ` Paul Walmsley
2011-08-10 7:27 ` Russell King - ARM Linux
2011-08-10 9:18 ` Tony Lindgren
2011-08-09 11:17 ` Péter Ujfalusi
2011-08-09 12:36 ` [PATCH] OMAP: Fix linking error in twl-common.c for OMAP2/3/4 only builds Peter Ujfalusi
2011-08-10 9:15 ` Tony Lindgren
2011-08-11 15:07 ` Michael Jones
2011-09-28 18:28 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110808110056.GA15134@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).