linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Marc.Dietrich@ap.physik.uni-giessen.de (Marc Dietrich)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ARM: tegra: paz00: add clocks required for usboperation
Date: Mon, 8 Aug 2011 19:18:41 +0200	[thread overview]
Message-ID: <201108081919.07647.marc.dietrich@ap.physik.uni-giessen.de> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF049F1721C1@HQMAIL01.nvidia.com>

Hi Stephen,

On Monday 08 August 2011 18:57:52 Stephen Warren wrote:
> Marc Dietrich wrote at Sunday, August 07, 2011 1:01 PM:
> > These clocks are required for usb operation.
> 
> ...
> 
> > diff --git a/arch/arm/mach-tegra/board-paz00.c
> > b/arch/arm/mach-tegra/board-paz00.c
> 
> ...
> 
> > @@ -145,6 +145,11 @@ static __initdata struct tegra_clk_init_table
> > paz00_clk_init_table[] = {
> > 
> >  	/* name		parent		rate		enabled */
> >  	{ "uarta",	"pll_p",	216000000,	true },
> >  	{ "uartd",	"pll_p",	216000000,	true },
> > 
> > +
> > +	{ "pll_a",      "pll_p_out1",   56448000,       true },
> > +	{ "pll_a_out0", "pll_a",        11289600,       true },
> 
> Are you sure those two are required for USB operation; they're typically
> used for audio. Of course, this might just be a bug in the commit
> description:-) Although, if you are attempting to enable audio, there's
> a bunch more stuff that'd need to be done, including some more clock
> setup.

Sorry, no audio yet :-( 

But yes, you are right. I just found them by trial-and-error method, so somehow 
these creeped in. So I guess that the *_a* stands for audio?

Corrected patch coming soon.

Thanks

Marc

  reply	other threads:[~2011-08-08 17:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-07 19:00 [PATCH 0/5] ARM: tegra: paz00: updates for "for-next" Marc Dietrich
2011-08-07 19:00 ` [PATCH 1/5] ARM: tegra: paz00: add support serial port on JP1 Marc Dietrich
2011-08-07 19:00 ` [PATCH 2/5] ARM: tegra: paz00: enable rfkill for internal wifi card Marc Dietrich
2011-08-07 19:00 ` [PATCH 3/5] ARM: tegra: paz00: enable wifi led Marc Dietrich
2011-08-07 19:00 ` [PATCH 4/5] ARM: tegra: paz00: add clocks required for usb operation Marc Dietrich
2011-08-08 16:57   ` Stephen Warren
2011-08-08 17:18     ` Marc Dietrich [this message]
2011-08-08 17:38       ` [PATCH 4/5] ARM: tegra: paz00: add clocks required for usboperation Stephen Warren
2011-08-08 21:15         ` [PATCH 4/5] ARM: tegra: paz00: add clocks required forusboperation Marc Dietrich
2011-08-09 18:29   ` [PATCH 4/5 V2] ARM: tegra: paz00: add clocks required for usb operation Marc Dietrich
2011-08-09 18:30     ` Olof Johansson
2011-08-09 19:18       ` Marc Dietrich
2011-08-09 19:24         ` Olof Johansson
2011-08-09 18:35     ` Stephen Warren
2011-08-07 19:00 ` [PATCH 5/5] ARM: tegra: paz00: reorder the SDHCI channel init Marc Dietrich
2011-08-09 19:35 ` [PATCH 0/5] ARM: tegra: paz00: updates for "for-next" Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108081919.07647.marc.dietrich@ap.physik.uni-giessen.de \
    --to=marc.dietrich@ap.physik.uni-giessen.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).