linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V3] ARM: tegra: paz00: add clocks required for usb operation
@ 2011-08-09 21:08 Marc Dietrich
  2011-08-10 11:24 ` Sergei Shtylyov
  0 siblings, 1 reply; 3+ messages in thread
From: Marc Dietrich @ 2011-08-09 21:08 UTC (permalink / raw)
  To: linux-arm-kernel


These clocks are required for usb operation. pll_p_out4 needs to be set
to 24 MHz. The other clocks default to "off" in order to safe some energy.
---
 arch/arm/mach-tegra/board-paz00.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-
paz00.c
index 45111f6..cde36dc 100644
--- a/arch/arm/mach-tegra/board-paz00.c
+++ b/arch/arm/mach-tegra/board-paz00.c
@@ -145,6 +145,12 @@ static __initdata struct tegra_clk_init_table 
paz00_clk_init_table[] = {
 	/* name		parent		rate		enabled */
 	{ "uarta",	"pll_p",	216000000,	true },
 	{ "uartd",	"pll_p",	216000000,	true },
+
+	{ "pll_p_out4",	"pll_p",	24000000,	true },
+	{ "usbd",	"clk_m",	12000000,	false },
+	{ "usb2",	"clk_m",	12000000,	false },
+	{ "usb3",	"clk_m",	12000000,	false },
+
 	{ NULL,		NULL,		0,		0},
 };
 
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH V3] ARM: tegra: paz00: add clocks required for usb operation
  2011-08-09 21:08 [PATCH V3] ARM: tegra: paz00: add clocks required for usb operation Marc Dietrich
@ 2011-08-10 11:24 ` Sergei Shtylyov
  2011-08-10 11:31   ` Marc Dietich
  0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2011-08-10 11:24 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 10-08-2011 1:08, Marc Dietrich wrote:

> These clocks are required for usb operation. pll_p_out4 needs to be set
> to 24 MHz. The other clocks default to "off" in order to safe some energy.

    s/safe/save/

    You didn't sign off on the patch.

> ---
>   arch/arm/mach-tegra/board-paz00.c |    6 ++++++
>   1 files changed, 6 insertions(+), 0 deletions(-)

> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-
> paz00.c
> index 45111f6..cde36dc 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -145,6 +145,12 @@ static __initdata struct tegra_clk_init_table
> paz00_clk_init_table[] = {
>   	/* name		parent		rate		enabled */
>   	{ "uarta",	"pll_p",	216000000,	true },
>   	{ "uartd",	"pll_p",	216000000,	true },
> +
> +	{ "pll_p_out4",	"pll_p",	24000000,	true },
> +	{ "usbd",	"clk_m",	12000000,	false },
> +	{ "usb2",	"clk_m",	12000000,	false },
> +	{ "usb3",	"clk_m",	12000000,	false },
> +
>   	{ NULL,		NULL,		0,		0},
>   };
>

WBR, Sergei

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH V3] ARM: tegra: paz00: add clocks required for usb operation
  2011-08-10 11:24 ` Sergei Shtylyov
@ 2011-08-10 11:31   ` Marc Dietich
  0 siblings, 0 replies; 3+ messages in thread
From: Marc Dietich @ 2011-08-10 11:31 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Sergei,

> On 10-08-2011 1:08, Marc Dietrich wrote:
> > These clocks are required for usb operation. pll_p_out4 needs to be set
> > to 24 MHz. The other clocks default to "off" in order to safe some
> > energy.
> 
>     s/safe/save/

ah yeah, my english needs some polish,

>     You didn't sign off on the patch.

and that's even worse. Time for V4 I guess.

Sorry for all the trouble.

Marc

> 
> > ---
> > 
> >   arch/arm/mach-tegra/board-paz00.c |    6 ++++++
> >   1 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-tegra/board-paz00.c
> > b/arch/arm/mach-tegra/board- paz00.c
> > index 45111f6..cde36dc 100644
> > --- a/arch/arm/mach-tegra/board-paz00.c
> > +++ b/arch/arm/mach-tegra/board-paz00.c
> > @@ -145,6 +145,12 @@ static __initdata struct tegra_clk_init_table
> > paz00_clk_init_table[] = {
> > 
> >   	/* name		parent		rate		enabled */
> >   	{ "uarta",	"pll_p",	216000000,	true },
> >   	{ "uartd",	"pll_p",	216000000,	true },
> > 
> > +
> > +	{ "pll_p_out4",	"pll_p",	24000000,	true },
> > +	{ "usbd",	"clk_m",	12000000,	false },
> > +	{ "usb2",	"clk_m",	12000000,	false },
> > +	{ "usb3",	"clk_m",	12000000,	false },
> > +
> > 
> >   	{ NULL,		NULL,		0,		0},
> >   
> >   };
> 
> WBR, Sergei

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-08-10 11:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-09 21:08 [PATCH V3] ARM: tegra: paz00: add clocks required for usb operation Marc Dietrich
2011-08-10 11:24 ` Sergei Shtylyov
2011-08-10 11:31   ` Marc Dietich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).