From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arch:arm:plat-omap:iovmm: remove unused variable 'va'
Date: Wed, 10 Aug 2011 04:18:05 -0700 [thread overview]
Message-ID: <20110810111804.GG1939@atomide.com> (raw)
In-Reply-To: <CAMhs6YwHbFknDpOg9e_5XcB-X9qo+DXX3tAaQy5xQopepeKOxw@mail.gmail.com>
* Maxin B John <maxin.john@gmail.com> [110810 04:06]:
> ping.
Sorry I've been on vacation, applying to fixes.
Regards,
Tony
> On Mon, Aug 8, 2011 at 1:15 PM, Maxin B. John <maxin.john@gmail.com> wrote:
> > The pointer "va" returned from "phys_to_virt(pa)" is never used in
> > "sgtable_fill_kmalloc()".So,it is safe to remove this set-but-unused variable.
> >
> > Signed-off-by: Maxin B. John <maxin.john@gmail.com>
> > ---
> > diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
> > index c60737c..79e7fed 100644
> > --- a/arch/arm/plat-omap/iovmm.c
> > +++ b/arch/arm/plat-omap/iovmm.c
> > @@ -423,9 +423,6 @@ static void sgtable_fill_kmalloc(struct sg_table *sgt, u32 pa, u32 da,
> > ?{
> > ? ? ? ?unsigned int i;
> > ? ? ? ?struct scatterlist *sg;
> > - ? ? ? void *va;
> > -
> > - ? ? ? va = phys_to_virt(pa);
> >
> > ? ? ? ?for_each_sg(sgt->sgl, sg, sgt->nents, i) {
> > ? ? ? ? ? ? ? ?unsigned bytes;
> >
prev parent reply other threads:[~2011-08-10 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 10:15 [PATCH] arch:arm:plat-omap:iovmm: remove unused variable 'va' Maxin B. John
2011-08-10 11:12 ` Maxin B John
2011-08-10 11:18 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810111804.GG1939@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).