* [PATCH] arch:arm:plat-omap:iovmm: remove unused variable 'va'
@ 2011-08-08 10:15 Maxin B. John
2011-08-10 11:12 ` Maxin B John
0 siblings, 1 reply; 3+ messages in thread
From: Maxin B. John @ 2011-08-08 10:15 UTC (permalink / raw)
To: linux-arm-kernel
The pointer "va" returned from "phys_to_virt(pa)" is never used in
"sgtable_fill_kmalloc()".So,it is safe to remove this set-but-unused variable.
Signed-off-by: Maxin B. John <maxin.john@gmail.com>
---
diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
index c60737c..79e7fed 100644
--- a/arch/arm/plat-omap/iovmm.c
+++ b/arch/arm/plat-omap/iovmm.c
@@ -423,9 +423,6 @@ static void sgtable_fill_kmalloc(struct sg_table *sgt, u32 pa, u32 da,
{
unsigned int i;
struct scatterlist *sg;
- void *va;
-
- va = phys_to_virt(pa);
for_each_sg(sgt->sgl, sg, sgt->nents, i) {
unsigned bytes;
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] arch:arm:plat-omap:iovmm: remove unused variable 'va'
2011-08-08 10:15 [PATCH] arch:arm:plat-omap:iovmm: remove unused variable 'va' Maxin B. John
@ 2011-08-10 11:12 ` Maxin B John
2011-08-10 11:18 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Maxin B John @ 2011-08-10 11:12 UTC (permalink / raw)
To: linux-arm-kernel
ping.
On Mon, Aug 8, 2011 at 1:15 PM, Maxin B. John <maxin.john@gmail.com> wrote:
> The pointer "va" returned from "phys_to_virt(pa)" is never used in
> "sgtable_fill_kmalloc()".So,it is safe to remove this set-but-unused variable.
>
> Signed-off-by: Maxin B. John <maxin.john@gmail.com>
> ---
> diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
> index c60737c..79e7fed 100644
> --- a/arch/arm/plat-omap/iovmm.c
> +++ b/arch/arm/plat-omap/iovmm.c
> @@ -423,9 +423,6 @@ static void sgtable_fill_kmalloc(struct sg_table *sgt, u32 pa, u32 da,
> ?{
> ? ? ? ?unsigned int i;
> ? ? ? ?struct scatterlist *sg;
> - ? ? ? void *va;
> -
> - ? ? ? va = phys_to_virt(pa);
>
> ? ? ? ?for_each_sg(sgt->sgl, sg, sgt->nents, i) {
> ? ? ? ? ? ? ? ?unsigned bytes;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] arch:arm:plat-omap:iovmm: remove unused variable 'va'
2011-08-10 11:12 ` Maxin B John
@ 2011-08-10 11:18 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2011-08-10 11:18 UTC (permalink / raw)
To: linux-arm-kernel
* Maxin B John <maxin.john@gmail.com> [110810 04:06]:
> ping.
Sorry I've been on vacation, applying to fixes.
Regards,
Tony
> On Mon, Aug 8, 2011 at 1:15 PM, Maxin B. John <maxin.john@gmail.com> wrote:
> > The pointer "va" returned from "phys_to_virt(pa)" is never used in
> > "sgtable_fill_kmalloc()".So,it is safe to remove this set-but-unused variable.
> >
> > Signed-off-by: Maxin B. John <maxin.john@gmail.com>
> > ---
> > diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
> > index c60737c..79e7fed 100644
> > --- a/arch/arm/plat-omap/iovmm.c
> > +++ b/arch/arm/plat-omap/iovmm.c
> > @@ -423,9 +423,6 @@ static void sgtable_fill_kmalloc(struct sg_table *sgt, u32 pa, u32 da,
> > ?{
> > ? ? ? ?unsigned int i;
> > ? ? ? ?struct scatterlist *sg;
> > - ? ? ? void *va;
> > -
> > - ? ? ? va = phys_to_virt(pa);
> >
> > ? ? ? ?for_each_sg(sgt->sgl, sg, sgt->nents, i) {
> > ? ? ? ? ? ? ? ?unsigned bytes;
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-10 11:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-08 10:15 [PATCH] arch:arm:plat-omap:iovmm: remove unused variable 'va' Maxin B. John
2011-08-10 11:12 ` Maxin B John
2011-08-10 11:18 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).