From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix perf build with uclibc toolchains
Date: Wed, 10 Aug 2011 12:56:00 +0200 [thread overview]
Message-ID: <201108101256.01010.florian@openwrt.org> (raw)
In-Reply-To: <20110810102154.GF10121@e102144-lin.cambridge.arm.com>
On Wednesday 10 August 2011 12:21:55 Will Deacon wrote:
> On Tue, Aug 09, 2011 at 09:08:53PM +0100, Will Deacon wrote:
> > On Tue, Aug 09, 2011 at 12:24:17PM +0100, Florian Fainelli wrote:
> > > libio.h is not provided by uClibc, in order to be able to test the
> > > definition of __UCLIBC__ we need to include stdlib.h, which also
> > > includes stddef.h, providing the definition of 'NULL'.
> > >
> > > Signed-off-by: Florian Fainelli <florian@openwrt.org>
> > > ---
> > > diff --git a/tools/perf/arch/arm/util/dwarf-regs.c
> > > b/tools/perf/arch/arm/util/dwarf-regs.c index fff6450..e8d5c55 100644
> > > --- a/tools/perf/arch/arm/util/dwarf-regs.c
> > > +++ b/tools/perf/arch/arm/util/dwarf-regs.c
> > > @@ -8,7 +8,10 @@
> > >
> > > * published by the Free Software Foundation.
> > > */
> > >
> > > +#include <stdlib.h>
> > > +#ifndef __UCLIBC__
> > >
> > > #include <libio.h>
> > >
> > > +#endif
> > >
> > > #include <dwarf-regs.h>
> > >
> > > struct pt_regs_dwarfnum {
> >
> > Nice to see somebody trying to get this going with uclinux! I'll give
> > this a quick compile-check on my boards and then I'll include it in my
> > perf-fixes branch for 3.1.
>
> Seems happy enough on my MMU boards. Since you're using this on noMMU
> platforms, does that mean that you can build a static perf binary out of
> the box or do you need further patches for this?
uClibc is not only for noMMU boards, I just built an uclibc toolchain for arm
targetting realview and run-tested this with qemu. This was the only patch
required to cross-compile perf for me. I also tested this with eglibc.
By the way, perf top reports no even being generated for realview under qemu,
is that normal?
--
Florian
next prev parent reply other threads:[~2011-08-10 10:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 11:24 [PATCH] ARM: fix perf build with uclibc toolchains Florian Fainelli
2011-08-09 20:08 ` Will Deacon
2011-08-10 10:21 ` Will Deacon
2011-08-10 10:56 ` Florian Fainelli [this message]
2011-08-10 12:26 ` Will Deacon
2011-08-10 13:08 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108101256.01010.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).