From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] arm/imx: remove the uses of gpio_to_irq()
Date: Fri, 12 Aug 2011 09:00:00 +0100 [thread overview]
Message-ID: <20110812080000.GF4775@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1313135701-22456-3-git-send-email-shawn.guo@linaro.org>
On Fri, Aug 12, 2011 at 03:54:57PM +0800, Shawn Guo wrote:
> gpio_to_irq() is too generic to be defined and used by i.mx platform
> code. The patch defines IMX_GPIO_TO_IRQ() in mach/hardware.h and
> replaces all the uses of gpio_to_irq() with IMX_GPIO_TO_IRQ().
That makes no sense. Why not continue to use gpio_to_irq() but provide
the .to_irq method in your gpiolib driver so it can work, and use that
in the places where its used at runtime?
(You won't be able to use it for static initialization obviously.)
next prev parent reply other threads:[~2011-08-12 8:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 7:54 [PATCH 0/6] Clean up plat-mxc/include/mach/gpio.h Shawn Guo
2011-08-12 7:54 ` [PATCH 1/6] arm/cpuimx51: gpio_to_irq() should be used to get irq from gpio number Shawn Guo
2011-08-12 9:36 ` Jason Liu
2011-08-12 11:13 ` Shawn Guo
2011-08-13 9:35 ` Russell King - ARM Linux
2011-08-13 12:12 ` Shawn Guo
2011-08-12 7:54 ` [PATCH 2/6] arm/imx: remove the uses of gpio_to_irq() Shawn Guo
2011-08-12 8:00 ` Russell King - ARM Linux [this message]
2011-08-12 8:22 ` Shawn Guo
2011-08-12 8:25 ` Shawn Guo
2011-08-12 8:57 ` Russell King - ARM Linux
2011-08-12 9:27 ` Shawn Guo
2011-08-12 7:54 ` [PATCH 3/6] gpio/mxc: add .to_irq for gpio chip Shawn Guo
2011-08-12 7:54 ` [PATCH 4/6] arm/imx: remove gpio_to_irq() from mach/gpio.h Shawn Guo
2011-08-12 7:55 ` [PATCH 5/6] gpio/mxc: move irq_to_gpio() into gpio-mxc driver Shawn Guo
2011-08-12 7:55 ` [PATCH 6/6] arm/mxc: move IMX_GPIO_NR into mach/hardware.h Shawn Guo
2011-08-12 8:02 ` Russell King - ARM Linux
2011-08-12 8:23 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812080000.GF4775@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).