linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: PB1176 broken in -rc1
Date: Tue, 16 Aug 2011 11:09:06 +0100	[thread overview]
Message-ID: <20110816100906.GA16159@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110816095936.GE28656@e102144-lin.cambridge.arm.com>

On Tue, Aug 16, 2011 at 10:59:36AM +0100, Will Deacon wrote:
> The problem is with earlyprintk because your picking up multiple definitions
> of DEBUG_LL_UART_OFFSET as a result of basing your config on the defconfig.
> 
> Take a look at arch/arm/mach-realview/include/mach/debug-macro.S. I don't
> think there's an easy way to fix this because it's used so early, even DT
> can't save us.

As I keep saying to people, only use the LL debug during _early_ platform
bring-up.  That's what it's there for.

Tying earlyprintk into the LL debug stuff has made the LL debug easier to
use, and therefore easier for people to fall into this trap.  That's not
the problem of the LL debug stuff, but the problem of its greater exposure.

So, as the LL debug stuff has this rule, so does earlyprintk.  Only use it
for early platform bring up and *once* you have a kernel booting through
to the proper console, disable it *immediately*.

Anything else will lead you into these pitfalls.

  reply	other threads:[~2011-08-16 10:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 15:24 PB1176 broken in -rc1 Will Deacon
2011-08-10 15:39 ` Jamie Iles
2011-08-10 15:53   ` Will Deacon
2011-08-11 13:02     ` Linus Walleij
2011-08-11 14:05 ` Linus Walleij
2011-08-11 14:24   ` Will Deacon
2011-08-16  9:21 ` Linus Walleij
2011-08-16  9:26   ` Will Deacon
2011-08-16  9:35     ` Linus Walleij
2011-08-16  9:59       ` Will Deacon
2011-08-16 10:09         ` Russell King - ARM Linux [this message]
2011-08-16 10:17           ` Will Deacon
2011-08-16 11:34             ` Russell King - ARM Linux
2011-08-16 21:38               ` Will Deacon
2011-08-16 12:44         ` Linus Walleij
2011-08-16 12:52           ` Russell King - ARM Linux
2011-08-16  9:28   ` Jamie Iles
2011-08-16  9:50     ` Jamie Iles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110816100906.GA16159@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).