From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/8] Clean up MXC and MXS mach/gpio.h
Date: Wed, 17 Aug 2011 08:47:37 +0200 [thread overview]
Message-ID: <20110817064737.GC31404@pengutronix.de> (raw)
In-Reply-To: <20110817062539.GC10037@S2100-06.ap.freescale.net>
On Wed, Aug 17, 2011 at 02:25:40PM +0800, Shawn Guo wrote:
> On Tue, Aug 16, 2011 at 09:19:50AM +0200, Sascha Hauer wrote:
> > Shawn,
> >
> > On Sun, Aug 14, 2011 at 12:13:59AM +0800, Shawn Guo wrote:
> > > As one step to single image for multiple platforms, mach/gpio.h needs
> > > to be removed from asm/gpio.h. The patch set cleans up MXC and MXS
> > > mach/gpio.h to an empty header.
> > >
> > > It's based on v3.1-rc1 plus rmk's patch series below.
> > >
> > > [PATCH 00/13] Clean up mach/gpio.h headers
> > >
> > > The Ben's fix is on the way to -rc2 through arm-soc tree.
> > >
> > > Grant, Sascha,
> > >
> > > Can you please review the series and give comments or your ack tag?
> >
> > I'm fine with this series. I removed the dependency on rmks patches
> > (can be easily merged later) and checked it into my cleanup branch.
> > Please check if you are fine with the result.
> >
> It looks all good in terms of code. But the commit messages of the
> following patches do not fit the context any more.
Yes, you are right. Changed it to the following
>
> arm/mxc: remove gpio_to_irq() from mach/gpio.h
arm/mxc: use gpiolib helper for gpio_to_irq
As all the users of gpio_to_irq() in static initializers have been
migrated to IMX_GPIO_TO_IRQ, we can start using the standard gpiolib
helper for gpio_to_irq().
> arm/mxc: move IMX_GPIO_NR into mach/hardware.h
arm/mxc: move IMX_GPIO_NR into mach/hardware.h
The patch moves IMX_GPIO_NR into mach/hardware.h, so that we only
use standard gpiolib helpers in mach/gpio.h.
> arm/mxs: move MXS_GPIO_NR into mach/mxs.h
arm/mxs: move MXS_GPIO_NR into mach/mxs.h
The patch moves MXS_GPIO_NR into mach/mxs.h, so that we only use
standard gpiolib helpers in mach/gpio.h.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2011-08-17 6:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-13 16:13 [PATCH v2 0/8] Clean up MXC and MXS mach/gpio.h Shawn Guo
2011-08-13 16:14 ` [PATCH v2 1/8] ARM: mx5: board-cpuimx51.c fixup irq_to_gpio() usage Shawn Guo
2011-08-13 16:14 ` [PATCH v2 2/8] arm/mxc: do not use gpio_to_irq() for static initializers Shawn Guo
2011-08-13 16:14 ` [PATCH v2 3/8] gpio/mxc: add .to_irq for gpio chip Shawn Guo
2011-08-13 16:14 ` [PATCH v2 4/8] arm/mxc: remove gpio_to_irq() from mach/gpio.h Shawn Guo
2011-08-13 16:14 ` [PATCH v2 5/8] gpio/mxc: move irq_to_gpio() into gpio-mxc driver Shawn Guo
2011-08-13 16:14 ` [PATCH v2 6/8] arm/mxc: move IMX_GPIO_NR into mach/hardware.h Shawn Guo
2011-08-13 16:14 ` [PATCH v2 7/8] gpio/mxs: move irq_to_gpio() into gpio-mxs driver Shawn Guo
2011-08-13 16:14 ` [PATCH v2 8/8] arm/mxs: move MXS_GPIO_NR into mach/mxs.h Shawn Guo
2011-08-16 7:19 ` [PATCH v2 0/8] Clean up MXC and MXS mach/gpio.h Sascha Hauer
2011-08-17 6:25 ` Shawn Guo
2011-08-17 6:47 ` Sascha Hauer [this message]
2011-08-17 7:10 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110817064737.GC31404@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).