From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] ARM: highbank: add SMP support
Date: Wed, 17 Aug 2011 19:52:48 +0100 [thread overview]
Message-ID: <20110817185248.GB11221@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4E4BC9D2.9090908@gmail.com>
On Wed, Aug 17, 2011 at 09:01:54AM -0500, Rob Herring wrote:
> On 08/17/2011 02:37 AM, Russell King - ARM Linux wrote:
> > On Tue, Aug 16, 2011 at 03:34:56PM -0500, Rob Herring wrote:
> >> +void __init smp_init_cpus(void)
> >> +{
> >> + void __iomem *scu_base = a9_base_addr;
> >> + unsigned int i, ncores;
> >> +
> >> + ncores = scu_base ? scu_get_core_count(scu_base) : 1;
> >
> > Is scu_base ever NULL?
>
> Only if something is wrong and the mapping did not get setup. The system
> should still boot with 1 core without accessing the the SCU in this case.
However, in a previous patch, a9_base_addr is statically initialized
and never written to, so that doesn't work. Not only that but its
also used for poweroff and cpu suspend...
> This BTW is the only reason we need a static mapping of the SCU. So I
> could just hard code it or use device tree to get the number of cores
> and eliminate the static mapping.
this statement isn't accurate.
I can see no way for scu_base to ever be NULL here.
next prev parent reply other threads:[~2011-08-17 18:52 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 20:34 [PATCH 0/6] Initial Calxeda Highbank support Rob Herring
2011-08-16 20:34 ` [PATCH 1/6] ARM: highbank: add devicetree source Rob Herring
2011-08-17 7:27 ` Shawn Guo
2011-08-17 13:49 ` Rob Herring
2011-08-17 14:51 ` Shawn Guo
2011-08-20 18:32 ` Rob Herring
2011-08-17 17:52 ` Will Deacon
2011-08-20 18:29 ` Rob Herring
2011-08-17 9:27 ` Mark Rutland
[not found] ` <4e4b8979.533fd80a.2ff3.1626SMTPIN_ADDED@mx.google.com>
2011-08-17 14:08 ` Rob Herring
2011-08-17 14:34 ` Will Deacon
2011-08-20 9:51 ` Shawn Guo
2011-08-20 18:19 ` Rob Herring
2011-08-16 20:34 ` [PATCH 2/6] ARM: add Highbank core platform support Rob Herring
2011-08-16 22:19 ` Jamie Iles
2011-08-25 2:19 ` Rob Herring
2011-08-17 7:43 ` Russell King - ARM Linux
2011-08-18 15:34 ` Arnd Bergmann
2011-08-18 15:40 ` Russell King - ARM Linux
2011-08-19 14:11 ` Arnd Bergmann
2011-08-20 19:24 ` Rob Herring
2011-08-20 23:05 ` Russell King - ARM Linux
2011-08-20 18:44 ` Rob Herring
2011-08-25 2:45 ` Rob Herring
2011-08-25 4:03 ` Shawn Guo
2011-08-25 15:59 ` Arnd Bergmann
2011-08-25 16:02 ` Arnd Bergmann
2011-08-25 18:03 ` Rob Herring
2011-08-25 21:44 ` Arnd Bergmann
2011-08-19 6:43 ` Shawn Guo
2011-08-19 7:17 ` Shawn Guo
2011-08-20 18:16 ` Rob Herring
2011-08-19 8:56 ` Dave Martin
2011-08-19 13:45 ` Arnd Bergmann
2011-08-20 14:48 ` Shawn Guo
2011-08-20 18:21 ` Rob Herring
2011-08-20 15:54 ` Shawn Guo
2011-08-20 16:10 ` Shawn Guo
2011-08-20 18:22 ` Rob Herring
2011-08-22 5:55 ` Shawn Guo
2011-08-22 10:01 ` Jamie Iles
2011-08-23 3:33 ` Shawn Guo
2011-08-22 8:35 ` Shawn Guo
2011-08-22 9:15 ` Shawn Guo
2011-08-22 13:23 ` Rob Herring
2011-08-16 20:34 ` [PATCH 3/6] MAINTAINERS: add Calxeda Highbank ARM platform Rob Herring
2011-08-16 20:34 ` [PATCH 4/6] ARM: highbank: add SMP support Rob Herring
2011-08-17 7:37 ` Russell King - ARM Linux
2011-08-17 14:01 ` Rob Herring
2011-08-17 18:52 ` Russell King - ARM Linux [this message]
2011-08-16 20:34 ` [PATCH 5/6] ARM: highbank: Add cpu hotplug support Rob Herring
2011-08-16 20:34 ` [PATCH 6/6] ARM: highbank: add suspend support Rob Herring
2011-08-25 1:17 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110817185248.GB11221@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).