linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/10] Clean up some io.h and associated code
Date: Thu, 18 Aug 2011 17:14:47 +0200	[thread overview]
Message-ID: <201108181714.47464.arnd@arndb.de> (raw)
In-Reply-To: <20110817075104.GC1006@n2100.arm.linux.org.uk>

On Wednesday 17 August 2011, Russell King - ARM Linux wrote:
> This series does some cleanup of the mach/io.h header files and
> associated definitions, including getting rid of quite a lot of
> IO_SPACE_LIMIT definitions.

Hi Russell,

This looks very nice!

I did some research during the Cambourne meeting about of these
and found that the omap1 and a91 platforms also need the IO_SPACE_LIMIT
defined to 0xffffffff when CONFIG_AT91_CF or CONFIG_OMAP_CF are
set, so these fall into the same category as CONFIG_PCMCIA_SOC_COMMON.

How about a new Kconfig symbol for this special I/O mode that is
selected by the three drivers? That would take care of all remaning
PCCARD users and simplify the generic IO_SPACE_LIMIT definition to

#ifndef IO_SPACE_LIMIT
#if defined(CONFIG_IO_SPACE_VIRTUAL) /* maybe you have a better name */
#define IO_SPACE_LIMIT ((resource_size_t)0xffffffff)
#elif defined(CONFIG_PCI) || defined(CONFIG_ISA)
#define IO_SPACE_LIMIT ((resource_size_t)0xffff)
#else
#define IO_SPACE_LIMIT ((resource_size_t)0)
#endif
#endif

The platforms that currently use PCI or ISA in the same way can
then also set that symbol and get rid of their private definition, or
converted over to having a single 64k window.

	Arnd

  parent reply	other threads:[~2011-08-18 15:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-17  7:51 [PATCH 00/10] Clean up some io.h and associated code Russell King - ARM Linux
2011-08-17  7:51 ` [PATCH 01/10] ARM: io: s3c2410: remove ioaddr() Russell King - ARM Linux
2011-08-17  7:51 ` [PATCH 02/10] ARM: io: RiscPC: define io addresses relative to IO_BASE Russell King - ARM Linux
2011-08-17  7:52 ` [PATCH 03/10] ARM: io: ecard: move ioaddr() inside __ecard_address Russell King - ARM Linux
2011-08-17  7:52 ` [PATCH 04/10] ARM: io: ecard: remove ioaddr() from ecard.c Russell King - ARM Linux
2011-08-17  7:52 ` [PATCH 05/10] ARM: io: RiscPC: make EASI_BASE a void iomem pointer Russell King - ARM Linux
2011-08-17  7:53 ` [PATCH 06/10] ARM: io: RiscPC: eliminate private inb() et.al. definitions Russell King - ARM Linux
2011-08-17  7:53 ` [PATCH 07/10] ARM: io: add a default IO_SPACE_LIMIT definition Russell King - ARM Linux
2011-08-17  7:53 ` [PATCH 08/10] ARM: io: remove IO_SPACE_LIMIT from platforms with ISA/PCI and 64K window Russell King - ARM Linux
2011-08-17  7:54 ` [PATCH 09/10] ARM: io: remove IO_SPACE_LIMIT from platforms without PCI/ISA Russell King - ARM Linux
2011-08-17  7:54 ` [PATCH 10/10] ARM: io: remove IO_SPACE_LIMIT from SA11x0 Russell King - ARM Linux
2011-08-18 15:14 ` Arnd Bergmann [this message]
2011-08-21  8:37   ` [PATCH 00/10] Clean up some io.h and associated code Russell King - ARM Linux
2011-08-21 13:21     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108181714.47464.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).