From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] S3C2443: Move i2s clock definitions to common code
Date: Sun, 21 Aug 2011 18:13:32 +0100 [thread overview]
Message-ID: <20110821171332.GF28546@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <201108201801.29541.heiko@sntech.de>
On Sat, Aug 20, 2011 at 06:01:29PM +0200, Heiko St?bner wrote:
> +/* i2s-ref
> + *
> + * i2s bus reference clock, selectable from external, esysclk or epllref
> + *
> + * Note, this used to be two clocks, but was compressed into one.
> +*/
> +
> +struct clk *clk_i2s_srclist[] = {
> + [0] = &clk_i2s_eplldiv.clk,
> + [1] = &clk_i2s_ext,
> + [2] = &clk_epllref.clk,
> + [3] = &clk_epllref.clk,
> +};
Is there any reason not to make this static (have you run your patch
through checkpatch.pl ?)
next prev parent reply other threads:[~2011-08-21 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-20 15:57 [PATCH 0/4] S3C2416: Enable IIS and HSSPI clocks Heiko Stübner
2011-08-20 16:01 ` [PATCH 1/4] S3C2443: Move i2s clock definitions to common code Heiko Stübner
2011-08-21 17:13 ` Russell King - ARM Linux [this message]
2011-08-21 17:25 ` Heiko Stübner
2011-08-21 20:26 ` Marek Vasut
2011-08-21 21:11 ` Heiko Stübner
2011-08-23 3:42 ` Kukjin Kim
2011-08-23 20:28 ` Heiko Stübner
2011-08-20 16:02 ` [PATCH 2/4] S3C2443: Define constant for HSSPI pclk Heiko Stübner
2011-08-20 16:03 ` [PATCH 3/4] S3C2416: Add HSSPI clock sourced from EPLL Heiko Stübner
2011-08-20 16:03 ` [PATCH 4/4] S3C2443: Add hsspi-clock from pclk Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110821171332.GF28546@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).