From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: debug: use kconfig choice for selecting DEBUG_LL UART
Date: Sun, 21 Aug 2011 19:26:04 +0100	[thread overview]
Message-ID: <20110821182604.GI28546@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.00.1108211258490.20358@xanadu.home>
On Sun, Aug 21, 2011 at 01:35:33PM -0400, Nicolas Pitre wrote:
> On Sun, 21 Aug 2011, Russell King - ARM Linux wrote:
> > Plus you need the virtual address too, because the LL debug stuff is
> > there to debug around places like the initial assembly, before C code
> > is setup.
> 
> The kernel should determine or set up the virtual address by itself.  
> This is obviously not something we want the bootloader to provide.  For 
> the same reason, I've discarded the idea that the bootloader could 
> simply have provided via a DT node a small segment of code (it's only a 
> few assembly instructions after all) to drive the serial port because it 
> would require a stable mapping to match that code's idea of the register 
> locations.
Yes, and the virtual and physical base addresses are set via the
existing macros.
To take the virtual address out of that means that we then have to find
some way of storing that data - which can't be inside the normal kernel
bss or data sections.  BSS has not been zeroed at the point where we want
working DEBUG_LL stuff.
Defining a offset-fixed memory location from the kernel is fragile, and
will end up wasting the entire page - which would have to be permanently
reserved.
This is just getting _idiotic_.  There are times when "no" is the word
which has to be used, and this is one of them.
> I'm not trying to cover the full story.  This is mainly for 98% of those 
> cases where a plain serial port is used for both the DEBUG_LL _and_ the 
> early output from the decompressor.
So yet again we end up with another half baked "solution", which will
result in "end-users" being confused because it'll work on some stuff
but not on other stuff.
That is *no* solution what so ever.
> Those people with a JTAG debugger and the knowledge to use it really 
> don't need any generic infrastructure to get some early debugging 
> information out.  They can reconfigure their kernel and even hack the 
> source to suit their needs.  But the people who are going to be the main 
> consumers of a multi-SOC single-binary kernel won't be the ones 
> recompiling their kernel just to provide us with debugging info.
That is a stupid argument.  The people who need the early console are
those bringing up a new board.  By the act of being involved in bringing
up a new board, they are a developer.  They are not a user.  They will
be having to rebuild the kernel.
There is no technical problem here.  It's just entirely conceptual,
and one of trying to use stuff inappropriately.
next prev parent reply	other threads:[~2011-08-21 18:26 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-16 21:41 [PATCH 1/3] ARM: debug: use kconfig choice for selecting DEBUG_LL UART Will Deacon
2011-08-16 21:41 ` [PATCH 2/3] ARM: plat-samsung: use Kconfig choice for debug UART selection Will Deacon
2011-10-10 11:56   ` Thomas Abraham
2011-10-10 12:23     ` Will Deacon
2011-10-10 12:35       ` Thomas Abraham
2011-10-10 13:34         ` Will Deacon
2011-10-10 13:38           ` Thomas Abraham
2011-08-16 21:41 ` [PATCH 3/3] ARM: realview: " Will Deacon
2011-08-18  4:06 ` [PATCH 1/3] ARM: debug: use kconfig choice for selecting DEBUG_LL UART Nicolas Pitre
2011-08-18  9:33   ` Will Deacon
2011-08-18 16:11 ` Shawn Guo
2011-08-18 16:07   ` Will Deacon
2011-08-19  4:59     ` Shawn Guo
2011-08-19 11:08       ` Will Deacon
2011-08-19 11:37         ` Shawn Guo
2011-08-19 12:32           ` Will Deacon
2011-08-19 15:49             ` Nicolas Pitre
2011-08-21  9:14               ` Russell King - ARM Linux
2011-08-21 17:35                 ` Nicolas Pitre
2011-08-21 18:26                   ` Russell King - ARM Linux [this message]
2011-08-21 19:02                     ` Nicolas Pitre
2011-08-21 19:18                       ` Russell King - ARM Linux
2011-08-21 19:22                         ` Russell King - ARM Linux
2011-08-21 20:07                           ` Nicolas Pitre
2011-08-21 20:54                             ` Russell King - ARM Linux
2011-08-21 21:00                               ` Nicolas Pitre
2011-08-21 21:29                                 ` Russell King - ARM Linux
2011-08-21 22:00                                   ` Nicolas Pitre
2011-08-21 19:53                         ` Nicolas Pitre
2011-09-06  9:28                           ` Tony Lindgren
2011-09-06  9:37                             ` Russell King - ARM Linux
2011-09-06 10:27                               ` Tony Lindgren
2011-09-06 10:52                                 ` Russell King - ARM Linux
2011-09-06 11:01                                   ` Tony Lindgren
2011-09-06 11:07                                     ` Russell King - ARM Linux
2011-09-06 19:45                                       ` Uwe Kleine-König
2011-08-19 14:54           ` Nicolas Pitre
2011-08-19  4:56 ` [PATCH] arm/imx: use Kconfig choice for low-level debug UART selection Shawn Guo
2011-08-19  6:35   ` Sascha Hauer
2011-08-19  7:00     ` Shawn Guo
2011-08-19 11:09     ` Will Deacon
2011-08-19 11:39       ` Sascha Hauer
2011-08-19 12:35         ` Will Deacon
2011-08-19 17:15           ` Sascha Hauer
2011-08-21  9:18         ` Russell King - ARM Linux
2011-08-21 11:25           ` Will Deacon
2011-08-21 17:59           ` Nicolas Pitre
2011-08-21 18:17             ` Russell King - ARM Linux
2011-08-21 18:28               ` Nicolas Pitre
2011-08-21 18:33                 ` Russell King - ARM Linux
2011-11-22  8:58   ` Uwe Kleine-König
2011-11-22 11:50     ` Will Deacon
2011-11-22 13:02       ` Uwe Kleine-König
2011-11-22 13:20         ` Will Deacon
2011-11-22 13:30           ` Uwe Kleine-König
2011-11-22 15:48             ` Russell King - ARM Linux
2011-11-22 16:38               ` Uwe Kleine-König
2011-11-22 16:47                 ` Mark Brown
2011-11-22 17:13                   ` Uwe Kleine-König
2011-11-22 20:24                   ` Russell King - ARM Linux
2011-11-22 21:19                     ` Arnd Bergmann
2011-11-22 23:00                       ` Mark Brown
2011-11-23 10:57                         ` Will Deacon
2011-09-15 17:34 ` [PATCH 1/3] ARM: debug: use kconfig choice for selecting DEBUG_LL UART Stephen Boyd
2011-09-16 11:41   ` Will Deacon
2011-09-19 18:01     ` [PATCH 1/2] ARM: debug: Add CLSP711X_UART1 config choice Stephen Boyd
2011-09-19 18:01       ` [PATCH 2/2] ARM: debug: Move DEBUG_ICEDCC into the DEBUG_LL choice Stephen Boyd
2011-09-19 21:25       ` [PATCH 1/2] ARM: debug: Add CLSP711X_UART1 config choice Will Deacon
2011-09-19 22:12         ` Stephen Boyd
2011-09-19 22:41           ` Russell King - ARM Linux
2011-09-19 22:55             ` Stephen Boyd
2011-11-22 20:42               ` Russell King - ARM Linux
2011-09-19 23:14           ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20110821182604.GI28546@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).