From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 2/3] MTD : add helper functions library and header files for GPMI NAND driver
Date: Mon, 22 Aug 2011 13:20:55 +0200 [thread overview]
Message-ID: <201108221320.55929.marek.vasut@gmail.com> (raw)
In-Reply-To: <4E51E33C.8090800@freescale.com>
On Monday, August 22, 2011 07:03:56 AM Huang Shijie wrote:
> Hi,
>
> > On Wednesday, August 17, 2011 01:50:27 PM Huang Shijie wrote:
> >> bch-regs.h : registers file for BCH module
> >> gpmi-regs.h: registers file for GPMI module
> >> gpmi-lib.c: helper functions library.
> >>
> >> Signed-off-by: Huang Shijie<b32955@freescale.com>
> >> ---
[...]
> >> +err_out:
> >> + return ret;
> >> +}
> >> +
> >> +/* This is very useful! */
> >
> > Really? Cool, what for ?
> > btw. this should really be enclosed in some #ifdef debug or whatnot.
>
> Yes, it shows the register contents when DMA timeout occurs.
> this routine is called only when error occurs.
>
Hi,
I'd expect exactly this explanation to be in the comment ;-)
Cheers
next prev parent reply other threads:[~2011-08-22 11:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 11:50 [PATCH v9 0/3] add the GPMI controller driver for IMX23/IMX28 Huang Shijie
2011-08-17 11:50 ` [PATCH v9 1/3] MTD : add the common code for GPMI-NAND controller driver Huang Shijie
2011-08-18 5:55 ` Huang Shijie
2011-08-20 5:35 ` Artem Bityutskiy
2011-08-22 4:34 ` Huang Shijie
2011-08-22 6:26 ` Artem Bityutskiy
2011-08-22 6:45 ` Huang Shijie
2011-08-22 13:11 ` Marek Vasut
2011-08-22 13:11 ` Marek Vasut
2011-08-20 11:43 ` Marek Vasut
2011-08-22 4:59 ` Huang Shijie
2011-08-22 13:09 ` Marek Vasut
2011-08-22 14:00 ` Huang Shijie
2011-08-22 14:02 ` Marek Vasut
2011-08-22 14:12 ` Huang Shijie
2011-08-23 10:27 ` Huang Shijie
2011-08-23 10:34 ` Marek Vasut
2011-08-23 10:38 ` Huang Shijie
2011-08-17 11:50 ` [PATCH v9 2/3] MTD : add helper functions library and header files for GPMI NAND driver Huang Shijie
2011-08-20 11:46 ` Marek Vasut
2011-08-22 5:03 ` Huang Shijie
2011-08-22 11:20 ` Marek Vasut [this message]
2011-08-22 13:41 ` Huang Shijie
2011-08-17 11:50 ` [PATCH v9 3/3] MTD : add GPMI-NAND driver in the config and Makefile Huang Shijie
2011-08-19 2:48 ` [PATCH v9 0/3] add the GPMI controller driver for IMX23/IMX28 Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108221320.55929.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).