From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: 46dcfc8 (ARM: Update mach-types) removes used machine types
Date: Mon, 22 Aug 2011 15:16:00 +0200 [thread overview]
Message-ID: <201108221516.00540.marek.vasut@gmail.com> (raw)
In-Reply-To: <20110822130119.GC2287@n2100.arm.linux.org.uk>
On Monday, August 22, 2011 03:01:19 PM Russell King - ARM Linux wrote:
> On Mon, Aug 22, 2011 at 01:56:53PM +0100, Russell King - ARM Linux wrote:
> > On Mon, Aug 22, 2011 at 02:54:55PM +0200, Marek Vasut wrote:
> > > On Monday, August 22, 2011 02:49:30 PM Russell King - ARM Linux wrote:
> > > > On Mon, Aug 22, 2011 at 01:18:25PM +0200, Marek Vasut wrote:
> > > > > On Monday, August 22, 2011 10:33:29 AM Uwe Kleine-K?nig wrote:
> > > > > > On Mon, Aug 22, 2011 at 09:17:49AM +0100, Russell King - ARM Linux
wrote:
> > > > > > > On Mon, Aug 22, 2011 at 10:10:00AM +0200, Uwe Kleine-K?nig wrote:
> > > > > > > > Hello Russell,
> > > > > > > >
> > > > > > > > your commit 46dcfc8 that is in today's next among other
> > > > > > > > changes does:
> > > > > > > >
> > > > > > > > -eukrea_cpuimx25sd MACH_EUKREA_CPUIMX25
> > > > > > > > EUKREA_CPUIMX25 2820 -eukrea_cpuimx35sd
> > > > > > > > MACH_EUKREA_CPUIMX35
> > > > > > > > EUKREA_CPUIMX35 2821
> > > > > > > >
> > > > > > > > These two are both marked as "mainlined" on
> > > > > > > > http://www.arm.linux.org.uk/developer/machines/ and both are
> > > > > > > > actually used
> > > > > > > > (arch/arm/mach-imx/mach-{eukrea_cpuimx25,cpuimx35.c})
> > > > > > > >
> > > > > > > > Can you please add them back? Maybe it's worth to
> > > > > > > > double-check the other deletions?!
> > > > > > >
> > > > > > > No. They're removed because they're broken (look at them) -
> > > > > > > I've added additional checks so I don't have to waste
> > > > > > > _significant_ time fixing the entries time and time again.
> > > > > > >
> > > > > > > The requirement is that the machine_is_xxx() must match the
> > > > > > > MACH_xxx parts. If they don't, they will not exist in future
> > > > > > > updates.
> > > > > >
> > > > > > Ah, I wasn't aware of that requirement.
> > > > > >
> > > > > > Eric, these machine types are owned by you. Do you care to follow
> > > > > > up?
> > > > >
> > > > > Hi Russell,
> > > > >
> > > > > maybe it'd be worth at least pinging the people before you kill off
> > > > > the machine so they can come up with fix?
> > > >
> > > > I've no idea which get killed off, sorry.
> > >
> > > This EUKREA thing from what I understood was removed from the machine
> > > database and broke things.
> >
> > So? The entry was broken. The entry was changed after submission.
> > There was no communication with me to fix things up. Therefore I _do_
> > _not_ _care_ about it.
>
> For further reading, see:
> http://lists.arm.linux.org.uk/lurker/message/20110815.085325.ae6ee07d.en.ht
> ml
Russell, calm down please.
Maybe it'd be better to just email the people with broken stuff, then wait ... if
they don't reply in a week (two weeks?) then remove their stuff. And make that a
policy.
What do you think ?
Cheers
next prev parent reply other threads:[~2011-08-22 13:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 8:10 46dcfc8 (ARM: Update mach-types) removes used machine types Uwe Kleine-König
2011-08-22 8:17 ` Russell King - ARM Linux
2011-08-22 8:33 ` Uwe Kleine-König
2011-08-22 11:18 ` Marek Vasut
2011-08-22 12:49 ` Russell King - ARM Linux
2011-08-22 12:54 ` Marek Vasut
2011-08-22 12:56 ` Russell King - ARM Linux
2011-08-22 13:01 ` Russell King - ARM Linux
2011-08-22 13:16 ` Marek Vasut [this message]
2011-08-22 13:27 ` Russell King - ARM Linux
2011-08-22 13:30 ` Marek Vasut
2011-08-22 13:32 ` Russell King - ARM Linux
2011-08-22 13:36 ` Marek Vasut
2011-08-22 13:48 ` Russell King - ARM Linux
2011-08-22 14:09 ` Eric Miao
2011-08-22 13:04 ` Eric Bénard
2011-08-22 13:55 ` Russell King - ARM Linux
2011-08-22 14:19 ` [PATCH] cpuimx* boards: fix mach-types errors Eric Bénard
2011-08-22 14:37 ` Russell King - ARM Linux
2011-08-22 14:43 ` Eric Bénard
2011-08-22 12:55 ` 46dcfc8 (ARM: Update mach-types) removes used machine types Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108221516.00540.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).