From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: of_iomap() matched with plan iounmap()
Date: Mon, 22 Aug 2011 16:07:25 +0200 [thread overview]
Message-ID: <201108221607.25179.arnd@arndb.de> (raw)
In-Reply-To: <20110819.062609.1865751197015675220.davem@davemloft.net>
On Friday 19 August 2011, David Miller wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Fri, 19 Aug 2011 14:26:18 +0200
>
> > We could of course change all existing users of of_iounmap on sparc to use
> > the simpler prototype, because it also just calls iounmap.
>
> Check again, on sparc64 it needs the resource to release it.
>
> Only the 32-bit version on sparc evaluates to just a plain iounmap().
Ok, I see.
On Friday 19 August 2011, David Brown wrote:
> What if we left the SPARC calls alone, and changed of_iomap() into
> of_dt_iomap() and could then make of_dt_iounmap(). Or, it could just
> be of_dt_map(), and of_dt_unmap().
I think at some point in the future, we will have a mass-renaming
of of_* to dt_* or similar, which would result in a silly name.
Also, the of_iomap() name is modeled after pci_iomap/pci_iomap.
How about renaming the sparc of_ioremap/of_iounmap pair to
resource_iomap/resource_iounmap? I believe that it is not
(any more) tied to device tree based probing at all, and also
could be useful for other subsystems on non-sparc architectures.
Arnd
next prev parent reply other threads:[~2011-08-22 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 17:02 of_iomap() matched with plan iounmap() David Brown
2011-08-19 3:34 ` David Miller
2011-08-19 12:26 ` Arnd Bergmann
2011-08-19 13:26 ` David Miller
2011-08-22 14:07 ` Arnd Bergmann [this message]
2011-08-22 18:47 ` David Miller
2011-08-19 21:19 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108221607.25179.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox