* [PATCH] ARM: mx27: Print silicon revision on boot
@ 2011-08-22 15:52 Fabio Estevam
2011-08-22 16:05 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2011-08-22 15:52 UTC (permalink / raw)
To: linux-arm-kernel
Silicon revision is useful information to have during kernel boot.
Print the MX27 silicon revision.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/mach-imx/clock-imx27.c | 1 +
arch/arm/mach-imx/cpu-imx27.c | 23 +++++++++++++++++++++++
arch/arm/plat-mxc/include/mach/mx27.h | 1 +
3 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-imx/clock-imx27.c b/arch/arm/mach-imx/clock-imx27.c
index 6912b82..2858137 100644
--- a/arch/arm/mach-imx/clock-imx27.c
+++ b/arch/arm/mach-imx/clock-imx27.c
@@ -756,6 +756,7 @@ int __init mx27_clocks_init(unsigned long fref)
clk_enable(&uart1_clk);
#endif
+ mx27_read_cpu_rev();
mxc_timer_init(&gpt1_clk, MX27_IO_ADDRESS(MX27_GPT1_BASE_ADDR),
MX27_INT_GPT1);
diff --git a/arch/arm/mach-imx/cpu-imx27.c b/arch/arm/mach-imx/cpu-imx27.c
index 3b117be..8f6495e 100644
--- a/arch/arm/mach-imx/cpu-imx27.c
+++ b/arch/arm/mach-imx/cpu-imx27.c
@@ -74,3 +74,26 @@ int mx27_revision(void)
return cpu_silicon_rev;
}
EXPORT_SYMBOL(mx27_revision);
+
+void __init mx27_read_cpu_rev(void)
+{
+ u32 rev;
+ char *srev;
+
+ rev = mx27_revision();
+ switch (rev) {
+ case IMX_CHIP_REVISION_1_0:
+ srev = IMX_CHIP_REVISION_1_0_STRING;
+ break;
+ case IMX_CHIP_REVISION_2_0:
+ srev = IMX_CHIP_REVISION_2_0_STRING;
+ break;
+ case IMX_CHIP_REVISION_2_1:
+ srev = IMX_CHIP_REVISION_2_1_STRING;
+ break;
+ default:
+ srev = IMX_CHIP_REVISION_UNKNOWN_STRING;
+ }
+
+ pr_info("CPU identified as i.MX27, silicon rev %s\n", srev);
+}
diff --git a/arch/arm/plat-mxc/include/mach/mx27.h b/arch/arm/plat-mxc/include/mach/mx27.h
index 1dc1c52..76edec7 100644
--- a/arch/arm/plat-mxc/include/mach/mx27.h
+++ b/arch/arm/plat-mxc/include/mach/mx27.h
@@ -246,6 +246,7 @@ static inline void mx27_setup_weimcs(size_t cs,
#ifndef __ASSEMBLY__
extern int mx27_revision(void);
+extern void mx27_read_cpu_rev(void);
#endif
#endif /* ifndef __MACH_MX27_H__ */
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: mx27: Print silicon revision on boot
2011-08-22 15:52 [PATCH] ARM: mx27: Print silicon revision on boot Fabio Estevam
@ 2011-08-22 16:05 ` Marek Vasut
2011-08-22 16:10 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2011-08-22 16:05 UTC (permalink / raw)
To: linux-arm-kernel
On Monday, August 22, 2011 05:52:41 PM Fabio Estevam wrote:
> Silicon revision is useful information to have during kernel boot.
>
> Print the MX27 silicon revision.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/mach-imx/clock-imx27.c | 1 +
> arch/arm/mach-imx/cpu-imx27.c | 23 +++++++++++++++++++++++
> arch/arm/plat-mxc/include/mach/mx27.h | 1 +
> 3 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-imx/clock-imx27.c
> b/arch/arm/mach-imx/clock-imx27.c index 6912b82..2858137 100644
> --- a/arch/arm/mach-imx/clock-imx27.c
> +++ b/arch/arm/mach-imx/clock-imx27.c
> @@ -756,6 +756,7 @@ int __init mx27_clocks_init(unsigned long fref)
> clk_enable(&uart1_clk);
> #endif
>
> + mx27_read_cpu_rev();
> mxc_timer_init(&gpt1_clk, MX27_IO_ADDRESS(MX27_GPT1_BASE_ADDR),
> MX27_INT_GPT1);
>
> diff --git a/arch/arm/mach-imx/cpu-imx27.c b/arch/arm/mach-imx/cpu-imx27.c
> index 3b117be..8f6495e 100644
> --- a/arch/arm/mach-imx/cpu-imx27.c
> +++ b/arch/arm/mach-imx/cpu-imx27.c
> @@ -74,3 +74,26 @@ int mx27_revision(void)
> return cpu_silicon_rev;
> }
> EXPORT_SYMBOL(mx27_revision);
> +
> +void __init mx27_read_cpu_rev(void)
> +{
> + u32 rev;
> + char *srev;
> +
> + rev = mx27_revision();
> + switch (rev) {
> + case IMX_CHIP_REVISION_1_0:
> + srev = IMX_CHIP_REVISION_1_0_STRING;
> + break;
> + case IMX_CHIP_REVISION_2_0:
> + srev = IMX_CHIP_REVISION_2_0_STRING;
> + break;
> + case IMX_CHIP_REVISION_2_1:
> + srev = IMX_CHIP_REVISION_2_1_STRING;
> + break;
> + default:
> + srev = IMX_CHIP_REVISION_UNKNOWN_STRING;
> + }
I didn't check really, but can't you just do some kind of a numeric
transformation instead of storing strings ?
Cheers
> +
> + pr_info("CPU identified as i.MX27, silicon rev %s\n", srev);
> +}
> diff --git a/arch/arm/plat-mxc/include/mach/mx27.h
> b/arch/arm/plat-mxc/include/mach/mx27.h index 1dc1c52..76edec7 100644
> --- a/arch/arm/plat-mxc/include/mach/mx27.h
> +++ b/arch/arm/plat-mxc/include/mach/mx27.h
> @@ -246,6 +246,7 @@ static inline void mx27_setup_weimcs(size_t cs,
>
> #ifndef __ASSEMBLY__
> extern int mx27_revision(void);
> +extern void mx27_read_cpu_rev(void);
> #endif
>
> #endif /* ifndef __MACH_MX27_H__ */
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: mx27: Print silicon revision on boot
2011-08-22 16:05 ` Marek Vasut
@ 2011-08-22 16:10 ` Fabio Estevam
2011-08-22 16:43 ` Marek Vasut
2011-08-22 17:09 ` Sascha Hauer
0 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2011-08-22 16:10 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 22, 2011 at 1:05 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
...
>
> I didn't check really, but can't you just do some kind of a numeric
> transformation instead of storing strings ?
I am using the same approach used by other i.MX processors.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: mx27: Print silicon revision on boot
2011-08-22 16:10 ` Fabio Estevam
@ 2011-08-22 16:43 ` Marek Vasut
2011-08-22 17:09 ` Sascha Hauer
1 sibling, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2011-08-22 16:43 UTC (permalink / raw)
To: linux-arm-kernel
On Monday, August 22, 2011 06:10:46 PM Fabio Estevam wrote:
> On Mon, Aug 22, 2011 at 1:05 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> ...
>
> > I didn't check really, but can't you just do some kind of a numeric
> > transformation instead of storing strings ?
>
> I am using the same approach used by other i.MX processors.
Hi,
does that mean it's "obviously correct (TM)" ? To do it differently can sometimes
introduce smarted solution etc etc. Taking a quick look, it shouldn't be difficult
even.
Cheers
>
> Regards,
>
> Fabio Estevam
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: mx27: Print silicon revision on boot
2011-08-22 16:10 ` Fabio Estevam
2011-08-22 16:43 ` Marek Vasut
@ 2011-08-22 17:09 ` Sascha Hauer
2011-08-22 18:21 ` Marek Vasut
1 sibling, 1 reply; 6+ messages in thread
From: Sascha Hauer @ 2011-08-22 17:09 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 22, 2011 at 01:10:46PM -0300, Fabio Estevam wrote:
> On Mon, Aug 22, 2011 at 1:05 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> ...
> >
> > I didn't check really, but can't you just do some kind of a numeric
> > transformation instead of storing strings ?
>
> I am using the same approach used by other i.MX processors.
How about
imx_print_silicon_rev(const char *cpu, int srev)
{
if (srev == IMX_CHIP_REVISION_UNKNOWN)
pr_info("CPU identified as %s, unknown revision\n");
else
pr_info("CPU identified as %s, silicon rev %d.%d\n",
cpu, (srev >> 4) & 0xf, srev & 0xf);
}
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: mx27: Print silicon revision on boot
2011-08-22 17:09 ` Sascha Hauer
@ 2011-08-22 18:21 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2011-08-22 18:21 UTC (permalink / raw)
To: linux-arm-kernel
On Monday, August 22, 2011 07:09:11 PM Sascha Hauer wrote:
> On Mon, Aug 22, 2011 at 01:10:46PM -0300, Fabio Estevam wrote:
> > On Mon, Aug 22, 2011 at 1:05 PM, Marek Vasut <marek.vasut@gmail.com>
> > wrote: ...
> >
> > > I didn't check really, but can't you just do some kind of a numeric
> > > transformation instead of storing strings ?
> >
> > I am using the same approach used by other i.MX processors.
>
> How about
>
> imx_print_silicon_rev(const char *cpu, int srev)
> {
> if (srev == IMX_CHIP_REVISION_UNKNOWN)
> pr_info("CPU identified as %s, unknown revision\n");
> else
> pr_info("CPU identified as %s, silicon rev %d.%d\n",
> cpu, (srev >> 4) & 0xf, srev & 0xf);
> }
>
> Sascha
Looks good
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-08-22 18:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-22 15:52 [PATCH] ARM: mx27: Print silicon revision on boot Fabio Estevam
2011-08-22 16:05 ` Marek Vasut
2011-08-22 16:10 ` Fabio Estevam
2011-08-22 16:43 ` Marek Vasut
2011-08-22 17:09 ` Sascha Hauer
2011-08-22 18:21 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).