From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: error: implicit declaration of function 'machine_is_ventana'
Date: Tue, 23 Aug 2011 00:40:08 +0100 [thread overview]
Message-ID: <20110822234008.GC3895@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF04B24A376A@HQMAIL01.nvidia.com>
On Mon, Aug 22, 2011 at 04:11:50PM -0700, Stephen Warren wrote:
> Russell,
>
> Commit 46dcfc806a9f6834e6007449eac175f781058c49 "ARM: Update mach-types"
> removed the entry for Ventana (2927). In turn, this broke compilation of
> sound/soc/tegra/tegra_wm8903.c, since that calls machine_is_ventana().
> It looks like the machine is still registered at
> http://www.arm.linux.org.uk/developer/machines/. Can you explain what the
> removal policy is for arch/arm/tools/mach-types?
The policy has always been that the machine_is_xxx() matches the other
constants. Rather than having to edit those out by hand, the script
now does this for me automatically.
This means any I've missed in previous updates are now missing. And
if that means stuff was merged with the non-conforming entries, then
that's a problem.
It's not something I particularly care about because the responsibility
has always been on the submitter to talk to me if they want to change
those constants. As they haven't talked to me...
Please submit a patch to fix your use in the kernel, including updating
the mach-types file to conform. I'll then fix the machine registry by
hand.
next prev parent reply other threads:[~2011-08-22 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 23:11 error: implicit declaration of function 'machine_is_ventana' Stephen Warren
2011-08-22 23:40 ` Russell King - ARM Linux [this message]
2011-08-22 23:49 ` Stephen Warren
2011-08-23 0:01 ` Russell King - ARM Linux
2011-08-23 0:11 ` Stephen Warren
2011-08-23 14:21 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822234008.GC3895@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox