linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: buytenh@wantstofly.org (Lennert Buytenhek)
To: linux-arm-kernel@lists.infradead.org
Subject: plat-orion needs to enable PCIe ports for mv78xx0
Date: Tue, 23 Aug 2011 01:45:33 +0200	[thread overview]
Message-ID: <20110822234533.GA2109@wantstofly.org> (raw)
In-Reply-To: <4E4C33D5.3050508@drewtech.com>

On Wed, Aug 17, 2011 at 05:34:13PM -0400, Joey Oravec wrote:

> On the Discovery series chips (mv78xx0), the CPU control and status
> register at offset 0x20104 contains bits to enable / disable PCI
> express port0 and port1. Both ports default to disabled.
> 
> It looks the PCIe driver and existing board setup files do not set
> this bit; any boards that use PCIe and are working today might
> assume that the bootloader has already set the bit to enable these
> ports. I couldn't find anything in Marvell's documentation about
> timing, but the bits need to be set a long time before you touch any
> of the PCIe port registers.

(The delay referred to here is the time it takes for the PCIe link
to establish.)

I think the kernel should try to enable the PCIe ports if it finds them
to be disabled, and wait for some time to see if the link(s) come up.
(And if they don't, or if the ports were up when booting but link(s)
were down, disable the port(s) again.)

I also think the boot loader should enable the PCIe ports as soon as
possible if devices are known to be connected, to save on booting time.

      parent reply	other threads:[~2011-08-22 23:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-17 21:34 plat-orion needs to enable PCIe ports for mv78xx0 Joey Oravec
2011-08-22 14:21 ` Lennert Buytenhek
2011-08-22 23:45 ` Lennert Buytenhek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110822234533.GA2109@wantstofly.org \
    --to=buytenh@wantstofly.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).