From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: mach-bcmring: fix build error in core.c
Date: Tue, 23 Aug 2011 17:45:14 +0100 [thread overview]
Message-ID: <20110823164514.GG3895@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4E53D84F.5060604@broadcom.com>
On Tue, Aug 23, 2011 at 09:41:51AM -0700, Jiandong Zheng wrote:
> On 8/23/2011 4:18 AM, Maxin B. John wrote:
>> CC arch/arm/mach-bcmring/core.o
>> arch/arm/mach-bcmring/core.c: In function 'bcmring_init_timer':
>> arch/arm/mach-bcmring/core.c:238: error: implicit declaration of
>> function 'sp804_clockevents_register'
>> make[1]: *** [arch/arm/mach-bcmring/core.o] Error 1
>> make: *** [arch/arm/mach-bcmring] Error 2
>>
>> Please let me know your comments on this fix:
>>
>> Signed-off-by: Maxin B. John<maxin.john@gmail.com>
>> ---
>> diff --git a/arch/arm/mach-bcmring/core.c b/arch/arm/mach-bcmring/core.c
>> index 43eadbc..430da12 100644
>> --- a/arch/arm/mach-bcmring/core.c
>> +++ b/arch/arm/mach-bcmring/core.c
>> @@ -235,7 +235,7 @@ void __init bcmring_init_timer(void)
>> */
>> bcmring_clocksource_init();
>>
>> - sp804_clockevents_register(TIMER0_VA_BASE, IRQ_TIMER0, "timer0");
>> + sp804_clockevents_init(TIMER0_VA_BASE, IRQ_TIMER0, "timer0");
>> }
>>
>> struct sys_timer bcmring_timer = {
>>
> Signed-off-by: Jiandong Zheng <jdzheng@broadcom.com>
Don't you mean acked-by or reviewed-by?
> The same changes was in my comments on May 17 to Russell's serial
> patches to convert to sp804 clk dev, but seems it got lost.
Unfortunately... sorry about that.
next prev parent reply other threads:[~2011-08-23 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 11:18 [PATCH 1/2] arm: mach-bcmring: fix build error in core.c Maxin B. John
2011-08-23 16:41 ` Jiandong Zheng
2011-08-23 16:45 ` Russell King - ARM Linux [this message]
2011-08-23 16:59 ` Jiandong Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823164514.GG3895@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).