From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] ARM: CSR: add rtc i/o bridge interface for SiRFprimaII
Date: Tue, 23 Aug 2011 18:01:20 +0200 [thread overview]
Message-ID: <201108231801.20595.arnd@arndb.de> (raw)
In-Reply-To: <1314080152-30503-2-git-send-email-Baohua.Song@csr.com>
On Tuesday 23 August 2011, Barry Song wrote:
> From: Zhiwu Song <zhiwu.song@csr.com>
>
> The module is a bridge between the RTC clock domain and the CPU interface
> clock domain. ARM access the register of SYSRTC, GPSRTC and PWRC through
> this module.
>
> Signed-off-by: Zhiwu Song <zhiwu.song@csr.com>
> Signed-off-by: Barry Song <Baohua.Song@csr.com>
> ---
Acked-by: Arnd Bergmann <arnd@arndb.de>
Looks basically good now. Aside from the trivial things that Jamie
already pointed out, there is one more that I noticed:
> +
> +void __iomem *sirfsoc_rtciobrg_base;
> +static DEFINE_SPINLOCK(rtciobrg_lock);
sirfsoc_rtciobrg_base should be static as well. No other code can
properly access it anyway since the lock is static, too.
Arnd
next prev parent reply other threads:[~2011-08-23 16:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 6:15 [PATCH v2 0/4] ARM: CSR: add rtciobrg and PM support Barry Song
2011-08-23 6:15 ` [PATCH v2 1/4] ARM: CSR: add rtc i/o bridge interface for SiRFprimaII Barry Song
2011-08-23 8:48 ` Jamie Iles
2011-08-23 9:33 ` Barry Song
2011-08-23 9:53 ` Jamie Iles
2011-08-23 15:59 ` Arnd Bergmann
2011-08-24 1:45 ` Barry Song
2011-08-23 16:01 ` Arnd Bergmann [this message]
2011-08-23 16:15 ` Arnd Bergmann
2011-08-24 1:43 ` Barry Song
2011-08-24 1:42 ` Barry Song
2011-08-23 6:15 ` [PATCH v2 2/4] ARM: CSR: add PM sleep entry " Barry Song
2011-08-23 8:50 ` Jamie Iles
2011-08-23 9:08 ` Barry Song
2011-08-23 9:41 ` Russell King - ARM Linux
2011-08-27 9:53 ` Barry Song
2011-08-25 7:27 ` Shawn Guo
2011-08-25 7:30 ` Barry Song
2011-08-25 8:21 ` Shawn Guo
2011-08-25 8:21 ` Barry Song
2011-08-25 8:33 ` Barry Song
2011-08-25 15:56 ` Arnd Bergmann
2011-08-25 22:58 ` Barry Song
2011-08-23 6:15 ` [PATCH v2 3/4] ARM: L2X0: move l2x0_init out of .init section Barry Song
2011-08-23 6:15 ` [PATCH v2 4/4] ARM: CSR: add PM suspend/resume entries for SiRFprimaII L2 cache Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108231801.20595.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).