From: nbowler@elliptictech.com (Nick Bowler)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: vexpress: Use wfi macro in platform_do_lowpower.
Date: Wed, 24 Aug 2011 13:51:55 -0400 [thread overview]
Message-ID: <20110824175155.GA13380@elliptictech.com> (raw)
In-Reply-To: <20110822135952.GE2796@pulham.picochip.com>
On 2011-08-22 14:59 +0100, Jamie Iles wrote:
> On Mon, Aug 22, 2011 at 09:54:19AM -0400, Nick Bowler wrote:
> > Current Versatile Express CPU hotplug code includes a hardcoded WFI
> > instruction, in ARM encoding. When the kernel is compiled in Thumb-2
> > mode, this is invalid and causes the machine to hang hard when a CPU
> > is offlined.
> >
> > Using the wfi macro (which uses the appropriate assembler mnemonic)
> > causes the correct instruction to be emitted in either case. As a
> > consequence of this change, an apparently vestigial "cc" clobber is
> > dropped from the asm (the macro uses "memory" only).
> >
> > Signed-off-by: Nick Bowler <nbowler@elliptictech.com>
> > ---
>
> Reviewed-by: Jamie Iles <jamie@jamieiles.com>
>
> if it helps!
Thanks!
Since there seem to be no objections, I'll send this off to Russell's
tracker.
Cheers,
--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
prev parent reply other threads:[~2011-08-24 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 18:03 [PATCH RFC] ARM: vexpress: Use assembler mnemonic for WFI in platform_do_lowpower Nick Bowler
2011-08-19 18:15 ` Jamie Iles
2011-08-19 19:26 ` Nick Bowler
2011-08-19 21:14 ` Jamie Iles
2011-08-22 9:43 ` Catalin Marinas
2011-08-22 13:54 ` [PATCH v2] ARM: vexpress: Use wfi macro " Nick Bowler
2011-08-22 13:59 ` Jamie Iles
2011-08-24 17:51 ` Nick Bowler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110824175155.GA13380@elliptictech.com \
--to=nbowler@elliptictech.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).