From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/11] clk: Provide a dummy clk_unregister()
Date: Thu, 25 Aug 2011 12:12:54 +0100 [thread overview]
Message-ID: <20110825111254.GD2838@pulham.picochip.com> (raw)
In-Reply-To: <1314191759-16941-6-git-send-email-broonie@opensource.wolfsonmicro.com>
Hi Mark,
On Wed, Aug 24, 2011 at 02:15:54PM +0100, Mark Brown wrote:
> Even though unregistration is not actually supported by the clk API it is
> still useful to provide a clk_unregister() so that drivers can implement
> their unregistration code. This saves having to go back later and update
> them once unregistration is possible.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> include/linux/clk.h | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/clk.h b/include/linux/clk.h
> index 2ca4f66..df5c64f 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> @@ -149,6 +149,21 @@ extern struct clk_hw_ops clk_gate_ops;
> struct clk *clk_register(struct clk_hw_ops *ops, struct clk_hw *hw,
> const char *name);
>
> +/**
> + * clk_unregister - remove a clock
> + *
> + * @clk: clock to unregister
> + *
> + * Remove a clock from the clk subsystem. This is currently not
> + * implemented but is provided to allow unregistration code to be
> + * written in drivers ready for use when an implementation is
> + * provided.
> + */
> +static inline int clk_unregister(struct clk *clk)
> +{
> + return -ENOTSUPP;
> +}
ENOTSUPP is only defined in include/linux/errno.h which isn't included
here. I think either linux/errno.h needs to be included or use
EOPNOTSUPP?
Jamie
next prev parent reply other threads:[~2011-08-25 11:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 13:13 [PATCH 0/11] generic struct clk patches Mark Brown
2011-08-24 13:15 ` [PATCH 01/11] clk: Add a generic clock infrastructure Mark Brown
2011-08-24 13:15 ` [PATCH 02/11] clk: Implement clk_set_rate Mark Brown
2011-08-26 8:53 ` Sascha Hauer
2011-08-26 8:55 ` Mark Brown
2011-08-26 8:58 ` Sascha Hauer
2011-08-26 9:01 ` Mark Brown
2011-08-26 23:45 ` Turquette, Mike
2011-09-13 19:03 ` Stephen Boyd
2011-08-24 13:15 ` [PATCH 03/11] clk: Add fixed-rate clock Mark Brown
2011-08-24 13:15 ` [PATCH 04/11] clk: Add simple gated clock Mark Brown
2011-08-25 13:17 ` Jamie Iles
2011-09-13 19:03 ` Stephen Boyd
2011-08-24 13:15 ` [PATCH 05/11] clk: Prototype and document clk_register() Mark Brown
2011-09-13 19:03 ` Stephen Boyd
2011-08-24 13:15 ` [PATCH 06/11] clk: Provide a dummy clk_unregister() Mark Brown
2011-08-25 11:12 ` Jamie Iles [this message]
2011-08-24 13:15 ` [PATCH 07/11] clk: Constify struct clk_hw_ops Mark Brown
2011-08-24 13:15 ` [PATCH 08/11] clk: Avoid clock name collisions Mark Brown
2011-09-13 19:03 ` Stephen Boyd
2011-08-24 13:15 ` [PATCH 09/11] clk: Add Kconfig option to build all generic clk drivers Mark Brown
2011-08-24 13:15 ` [PATCH 10/11] clk: Add initial WM831x clock driver Mark Brown
2011-08-24 13:15 ` [PATCH 11/11] x86: Enable generic clk API on x86 Mark Brown
2011-09-13 19:03 ` [PATCH 01/11] clk: Add a generic clock infrastructure Stephen Boyd
[not found] ` <1314191759-16941-1-git-send-email-broonie@opensource.wolfsonmicro.com >
2011-09-14 2:22 ` Saravana Kannan
2011-09-14 9:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825111254.GD2838@pulham.picochip.com \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).