From: rjw@sisk.pl (Rafael J. Wysocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] OMAP: omap_device: only override _noirq methods, not normal suspend/resume
Date: Thu, 25 Aug 2011 16:12:42 +0200 [thread overview]
Message-ID: <201108251612.42237.rjw@sisk.pl> (raw)
In-Reply-To: <1314229437-31836-2-git-send-email-khilman@ti.com>
On Thursday, August 25, 2011, Kevin Hilman wrote:
> commit c03f007a8bf0e092caeb6856a5c8a850df10b974 (OMAP: PM:
> omap_device: add system PM methods for PM domain handling) mistakenly
> used SET_SYSTEM_SLEEP_PM_OPS() when trying to configure custom methods
> for the PM domains noirq methods. Fix that by setting only the
> suspend_noirq and resume_noirq methods with custom versions.
>
> Note that all other PM domain methods (including the "normal"
> suspend/resume methods) are populated using USE_PLATFORM_PM_SLEEP_OPS,
> which configures them all to the default subsystem (platform_bus)
> methods.
>
> Reported-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Tested-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
Applied to linux-pm/pm-fixes, will be pushed for 3.1, thanks!
Rafael
> ---
> arch/arm/plat-omap/omap_device.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c
> index b6b4097..9a6a538 100644
> --- a/arch/arm/plat-omap/omap_device.c
> +++ b/arch/arm/plat-omap/omap_device.c
> @@ -622,7 +622,8 @@ static struct dev_pm_domain omap_device_pm_domain = {
> SET_RUNTIME_PM_OPS(_od_runtime_suspend, _od_runtime_resume,
> _od_runtime_idle)
> USE_PLATFORM_PM_SLEEP_OPS
> - SET_SYSTEM_SLEEP_PM_OPS(_od_suspend_noirq, _od_resume_noirq)
> + .suspend_noirq = _od_suspend_noirq,
> + .resume_noirq = _od_resume_noirq,
> }
> };
>
>
next prev parent reply other threads:[~2011-08-25 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 23:43 [PATCH 0/1] PM: omap_device fix for v3.1-rc Kevin Hilman
2011-08-24 23:43 ` [PATCH 1/1] OMAP: omap_device: only override _noirq methods, not normal suspend/resume Kevin Hilman
2011-08-25 14:12 ` Rafael J. Wysocki [this message]
2011-09-01 16:00 ` Arnd Bergmann
2011-09-01 17:50 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108251612.42237.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).