From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: Fix builderror in spi-pl022.c
Date: Sun, 28 Aug 2011 21:06:48 +0100 [thread overview]
Message-ID: <20110828200648.GC13379@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1314559619-19923-1-git-send-email-peterhuewe@gmx.de>
On Sun, Aug 28, 2011 at 09:26:59PM +0200, Peter Huewe wrote:
> This patch fixes a build error, introduced by commit (67fc8b9f, "PM: add
> runtime PM support to core Primecell driver") which unfortunately was a little
> bit incomplete and did contain a typo (11 instead of 22).
> I'm not sure how this patch could have been tested back then, if it
> doesn't even compile ;)
Maybe it was tested on configs without CONFIG_SUSPEND enabled - which
is highly likely since my ARM development boards don't support S2RAM.
That's the problem with ifdef'ing code. It makes it impossible to
ensure that it's properly tested.
next prev parent reply other threads:[~2011-08-28 20:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 10:15 [PATCH 0/2] Add runtime PM support to Primecell bus Russell King - ARM Linux
2011-08-23 10:16 ` [PATCH 1/2] PM: add runtime PM support to core Primecell driver Russell King - ARM Linux
2011-08-23 22:24 ` Rafael J. Wysocki
2011-08-28 19:26 ` [PATCH] spi: Fix builderror in spi-pl022.c Peter Huewe
2011-08-28 20:06 ` Russell King - ARM Linux [this message]
2011-08-29 8:41 ` Linus Walleij
2011-09-05 12:45 ` Linus Walleij
2011-09-20 20:45 ` Linus Walleij
2011-09-20 21:52 ` Grant Likely
2011-09-21 13:10 ` Russell King - ARM Linux
2011-09-21 15:54 ` Linus Walleij
2011-08-23 10:16 ` [PATCH 2/2] PM: add runtime PM support to MMCI Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110828200648.GC13379@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).