From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S3C64XX: Fix clkdev device names for I2C clocks
Date: Wed, 31 Aug 2011 01:21:33 +0100 [thread overview]
Message-ID: <20110831002133.GA1164@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAH9JG2UEZVQ+5AJbbtXQhuVzvDp_8-wJdNgOjwHs14Zj7_KP+g@mail.gmail.com>
On Wed, Aug 31, 2011 at 08:48:03AM +0900, Kyungmin Park wrote:
> It's not matched with your description. and also not matched with
> codes at "arch/arm/mach-s3c64xx/s3c6410.c"
> /* the i2c devices are directly compatible with s3c2440 */
> s3c_i2c0_setname("s3c2440-i2c");
> s3c_i2c1_setname("s3c2440-i2c");
Oh, FFS. That's what's broken - the names that are actually appearing
in the system are the names that the devices have in the relevant
dev-i2c?.c files and obviously there's no reason one would expect to
find code like the above since it's just a little abstruse to rewrite
the devices like that.
Looking at the code I bet what broke it is the CPU revision
identification changes - it's now responsible for making sure the fixups
are run. Either it's not matching correctly or it's running too late to
make the fixup before the device is registered.
Though the first part of the issue (the fact that I2C0 isn't using a
device name and I2C1 is) remains an issue.
next prev parent reply other threads:[~2011-08-31 0:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 21:30 [PATCH] ARM: S3C64XX: Fix clkdev device names for I2C clocks Mark Brown
2011-08-30 23:48 ` Kyungmin Park
2011-08-31 0:21 ` Mark Brown [this message]
2011-08-31 8:14 ` Thomas Abraham
2011-08-31 10:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110831002133.GA1164@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).