From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] OMAP3: beagleboard: Remove DT support from regular board
Date: Fri, 2 Sep 2011 13:48:50 +0300 [thread overview]
Message-ID: <20110902104850.GS3548@atomide.com> (raw)
In-Reply-To: <4E609B0A.1020804@ti.com>
* Cousson, Benoit <b-cousson@ti.com> [110902 11:26]:
> On 9/2/2011 10:12 AM, Tony Lindgren wrote:
> >* Benoit Cousson<b-cousson@ti.com> [110901 19:52]:
> >>In order to avoid conflict with the new board-omap3-dt.c file,
> >>remove the .dt_compat entry from the beagle regular board
> >>file.
> >>
> >>Any DT work for OMAP3 will have to be done on the generic DT
> >>board file to avoid breaking the legacy board support until
> >>DT migration is done.
> >
> >In general we should not keep duplicate old non-DT data around
> >now that we have the DT append support. Instead we should just
> >require the .dts file appended to zImage for all mach-omap2
> >machines. Otherwise we'll end up with double bloat :)
>
> Mmm, I'm not sure to get your point. We are not duplicating, since a
> pure DT generic board will not have anything except a
> of_platform_populate(NULL, omap_dt_match_table, NULL, NULL);
> And the regular board files will keep initializing devices statically.
> The drivers will then for the moment support both pdata and DT
> method to get board parameters.
Well when converting a driver to DT, we should just drop pdata
support. No need to keep it around as it will just make it harder
for us to clean up afterwards.
> >So it's OK to have the DT entries in board files so drivers
> >that get converted will work with them.
>
> Well, it will be a little bit more tricky, because having DT in
> current board files will be a mess with a bunch of #ifdef CONFIG_OF,
> and adding DT compatible inside each boards will prevent the pure
> generic DT one to work. In that case we will duplicate the DT
> migration in every legacy boards files...
We should just select CONFIG_OF deal with it that way.
> That's why the current strategy is to keep the current board files
> non-DT aware and add the DT support only to the generic DT board
> file.
Well I don't like that, it will be a big mess. We'll end up with
twice the amount of platform_data and init code. It's OK to
require CONFIG_OF as it's known to work with the append support
for older boards.
It's easier just to require DT append for all the boards. In most
cases it's just a trivial include of the common dts file for now.
When we convert something to DT, there's no point going back.
Regards,
Tony
next prev parent reply other threads:[~2011-09-02 10:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 17:25 [PATCH 0/7] OMAP3: Add basic DT support + i2c + twl Benoit Cousson
2011-09-01 17:25 ` [PATCH 1/7] arm/dts: Add initial device-tree support for OMAP3 SoC Benoit Cousson
2011-09-01 17:25 ` [PATCH 2/7] arm/dts: OMAP3: Add mpu and iva nodes Benoit Cousson
2011-09-01 18:17 ` Arnd Bergmann
2011-09-05 15:05 ` Cousson, Benoit
2011-09-05 17:23 ` Arnd Bergmann
2011-09-05 17:46 ` Mitch Bradley
2011-09-06 7:15 ` Cousson, Benoit
2011-09-01 17:25 ` [PATCH 3/7] arm/dts: OMAP3: Add i2c controllers nodes Benoit Cousson
2011-09-01 17:25 ` [PATCH 4/7] arm/dts: omap3-beagle: Include the generic omap3.dtsi Benoit Cousson
2011-09-01 17:25 ` [PATCH 5/7] arm/dts: omap3-beagle: Add twl4030 and EEPROM i2c devices Benoit Cousson
2011-09-01 17:25 ` [PATCH 6/7] OMAP3: board-dt: Add generic board file for DT support Benoit Cousson
2011-09-02 8:09 ` Tony Lindgren
2011-09-02 8:46 ` Cousson, Benoit
2011-09-02 9:08 ` Russell King - ARM Linux
2011-09-02 9:13 ` Cousson, Benoit
2011-09-02 9:21 ` Russell King - ARM Linux
2011-09-02 9:34 ` Cousson, Benoit
2011-09-02 10:43 ` Tony Lindgren
2011-09-02 11:43 ` Cousson, Benoit
2011-09-02 11:57 ` Tony Lindgren
2011-09-02 12:20 ` Cousson, Benoit
2011-09-02 12:32 ` Tony Lindgren
2011-09-05 12:09 ` G, Manjunath Kondaiah
2011-09-01 17:25 ` [PATCH 7/7] OMAP3: beagleboard: Remove DT support from regular board Benoit Cousson
2011-09-02 8:12 ` Tony Lindgren
2011-09-02 8:59 ` Cousson, Benoit
2011-09-02 10:48 ` Tony Lindgren [this message]
2011-09-02 12:35 ` Cousson, Benoit
2011-09-02 13:08 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110902104850.GS3548@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).