From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [media] at91: add code to initialize and manage the ISI_MCK for Atmel ISI driver.
Date: Mon, 5 Sep 2011 11:33:39 +0100 [thread overview]
Message-ID: <20110905103339.GG6619@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1315218593-10822-1-git-send-email-josh.wu@atmel.com>
On Mon, Sep 05, 2011 at 06:29:53PM +0800, Josh Wu wrote:
> +static int initialize_mck(struct atmel_isi *isi,
> + struct isi_platform_data *pdata)
> +{
> + int ret;
> + struct clk *pck_parent;
> +
> + if (!strlen(pdata->pck_name) || !strlen(pdata->pck_parent_name))
> + return -EINVAL;
> +
> + /* ISI_MCK is provided by PCK clock */
> + isi->mck = clk_get(NULL, pdata->pck_name);
No, this is not how you use the clk API. You do not pass clock names via
platform data.
You pass clk_get() the struct device. You then pass clk_get() a
_connection id_ on that _device_ if you have more than one struct clk
associated with the _device_. You then use clkdev to associate the
struct device plus the connection id with the appropriate struct clk.
next prev parent reply other threads:[~2011-09-05 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 10:29 [PATCH] [media] at91: add code to initialize and manage the ISI_MCK for Atmel ISI driver Josh Wu
2011-09-05 10:33 ` Russell King - ARM Linux [this message]
2011-09-06 3:29 ` [PATCH] [media] at91: add code to initialize and manage theISI_MCK " Wu, Josh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110905103339.GG6619@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).