[PATCH 1/3 v3] ARM Realview PCIX map include file changes

Colin Tuckley
2011-10-06T14:50:36Z

> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
> Subject: Re: [PATCH 1/3 v3] ARM Realview PCIX map include file changes

> All the points in this email all go together.

Ah, that wasn't clear from the original email - I was making the changes incrementally and testing as I went.

> This is how it works:
>
> 1. The PCI IO window is _supposed_ to be 64K in size.

Yes, that bit was obvious after a bit of thought. I suspect the original value was just a cut 'n paste error.

> 2. "pcibios_min_io" sets the minimum offset into the PCI IO window
> which
> PCI IO BARs should be assigned. It is assumed that a PCI IO BAR
> value
> of 0 corresponds with the virtual base address of this window.
> 3. inb() et.al. take the PCI IO offset and _not_ the physical address
> nor the virtual address of the desired access.

That seems sensible.

However, after changing both __io() and pcibios_min_io as Arnd suggested the boot still hangs after " Uncompressing Linux... done, booting the kernel."

I did notice that there seems to have been some code changes and refactoring in the pci sub-system between 3.1 and 2.6.38 where I was testing before. Are there any significant changes I should be aware of?

Colin

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.